Attachment 63575 Details for Bug 18536 – Bug 18536: [QA Follow-up] Tiny regex simplification

[patch] Bug 18536: [QA Follow-up] Tiny regex simplification

Bug-18536-QA-Follow-up-Tiny-regex-simplification.patch (text/plain), 1.05 KB, created by Marcel de Rooy on 2017-05-19 09:43:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-05-19 09:43:01 UTC

Size: 1.05 KB

patch

obsolete

>From 11d962f0732869d86793098e98ede5aa53eeecd0 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 19 May 2017 11:39:24 +0200
>Subject: [PATCH] Bug 18536: [QA Follow-up] Tiny regex simplification
>Content-Type: text/plain; charset=utf-8
>
>Simplify regex for removing table name.
>No need to escape a dot between the square brackets. No need to specify a
>number of 1 between parentheses.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> serials/lateissues-export.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/serials/lateissues-export.pl b/serials/lateissues-export.pl
>index 0bd82a6..e36e734 100755
>--- a/serials/lateissues-export.pl
>+++ b/serials/lateissues-export.pl
>@@ -57,7 +57,7 @@ while ( $content =~ /
>     $header =~ s/^\s+|\s+$//g; # Trim whitespaces
>     push @headers, $header;
> 
>-    $field =~ s/[^\.]*\.{1}//; # Remove the table name if exists.
>+    $field =~ s/[^.]+\.//; # Remove the table name if exists.
>     $field =~ s/^\s+|\s+$//g; # Trim whitespaces
>     push @fields, $field;
> }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18536: 63058 | 63342 | 63373 | 63574 | 63575