Bugzilla – Attachment 63616 Details for
Bug 18596
Quick add form duplicating password confirm
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18596 - Quick add form duplicating password confirm
Bug-18596---Quick-add-form-duplicating-password-co.patch (text/plain), 1.84 KB, created by
Jonathan Druart
on 2017-05-22 13:42:41 UTC
(
hide
)
Description:
Bug 18596 - Quick add form duplicating password confirm
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-05-22 13:42:41 UTC
Size:
1.84 KB
patch
obsolete
>From e4afe2dc9d01a23e331a920eac78d62ada57b2dc Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Fri, 12 May 2017 09:18:45 -0400 >Subject: [PATCH] Bug 18596 - Quick add form duplicating password confirm > >To test: >1 - Add password to BorrowerMandatoryField >2 - View quick add form >3 - See confirm password twice >4 - Apply patch >5 - See confirm password once >6 - Add password to QuickAddFields >7 - Confirm one confirm field >8 - Remove password form BorrowerMandatory field >9 - Confirm there is one confirm field and password fields are not >required > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >index 5045714672..c9ca443a68 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt >@@ -1237,7 +1237,9 @@ $(document).ready(function() { > if ( skipped_fields.indexOf( input_label ) != -1 ) { input_label=""; } > if( qaddfields.indexOf( input_label ) != -1 || $(this).attr('class') == 'required' ){ > $(this).parent().clone().appendTo("#quick_add_list"); >- if( input_label == 'password') $("#entryform label[for='password2']").parent().clone().appendTo("#quick_add_list"); >+ [% UNLESS mandatorypassword %] >+ if( input_label == 'password' ) $("#entryform label[for='password2']").parent().clone().appendTo("#quick_add_list"); >+ [% END %] > } > }); > if( $("#memberentry_guarantor").length ) { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18596
:
63425
|
63426
|
63447
|
63449
|
63555
| 63616