Bugzilla – Attachment 63664 Details for
Bug 18662
Can not delete currencies
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18662: Fix currency deletion
Bug-18662-Fix-currency-deletion.patch (text/plain), 1.41 KB, created by
Marc Véron
on 2017-05-23 16:57:25 UTC
(
hide
)
Description:
Bug 18662: Fix currency deletion
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2017-05-23 16:57:25 UTC
Size:
1.41 KB
patch
obsolete
>From f2af2ad2999e3e09253fd6ff26261effa4e05788 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 23 May 2017 13:02:30 -0300 >Subject: [PATCH] Bug 18662: Fix currency deletion >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >Sounds like it is caused by bug 13726. >It is not possible to delete a currency, even if not used by any vendors > >Test plan: >Try and delete currencies used or not by vendors. > >Signed-off-by: Marc Véron <veron@veron.ch> >--- > admin/currency.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/admin/currency.pl b/admin/currency.pl >index 09b6a74..1c5ec3e 100755 >--- a/admin/currency.pl >+++ b/admin/currency.pl >@@ -95,7 +95,7 @@ if ( $op eq 'add_form' ) { > # TODO rewrite the following when Koha::Acquisition::Orders will use Koha::Objects > my $schema = Koha::Database->schema; > my $nb_of_orders = $schema->resultset('Aqorder')->search( { currency => $currency->currency } )->count; >- my $nb_of_vendors = Koha::Acquisition::Booksellers->search( { -or => { listprice => $currency->currency, invoiceprice => $currency->currency } }); >+ my $nb_of_vendors = Koha::Acquisition::Booksellers->search( { -or => { listprice => $currency->currency, invoiceprice => $currency->currency } })->count; > $template->param( > currency => $currency, > nb_of_orders => $nb_of_orders, >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18662
:
63662
|
63664
|
63699