Attachment 63674 Details for Bug 18478 – Bug 18478 - QA Followup

[patch] Bug 18478 - QA Followup

Bug-18478---QA-Followup.patch (text/plain), 1.48 KB, created by Nick Clemens (kidclamp) on 2017-05-23 20:11:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2017-05-23 20:11:56 UTC

Size: 1.48 KB

patch

obsolete

>From ec3e378ef5b6176e66365f6923ce8c083a072f1e Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 23 May 2017 16:11:06 -0400
>Subject: [PATCH] Bug 18478 - QA Followup
>
>Make sure to build necessary letters
>---
> t/db_dependent/Reserves.t | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
>diff --git a/t/db_dependent/Reserves.t b/t/db_dependent/Reserves.t
>index 0ac07f3..1a2d33c 100755
>--- a/t/db_dependent/Reserves.t
>+++ b/t/db_dependent/Reserves.t
>@@ -733,14 +733,30 @@ subtest '_koha_notify_reserve() tests' => sub {
>     };
> 
>     my $mp = Test::MockModule->new( 'C4::Members::Messaging' );
>+
>     $mp->mock("GetMessagingPreferences",$wants_hold_and_email);
> 
>-    my $sms_hold_notice = $builder->build_object({
>-            class => 'Koha::Notice::Templates',
>+    $dbh->do('DELETE FROM letter');
>+
>+    my $email_hold_notice = $builder->build({
>+            source => 'Letter',
>+            value => {
>+                message_transport_type => 'email',
>+                branchcode => '',
>+                code => 'HOLD',
>+                module => 'reserves',
>+                lang => 'default',
>+            }
>+        });
>+
>+    my $sms_hold_notice = $builder->build({
>+            source => 'Letter',
>             value => {
>                 message_transport_type => 'sms',
>                 branchcode => '',
>                 code => 'HOLD',
>+                module => 'reserves',
>+                lang=>'default',
>             }
>         });
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18478: 63487 | 63488 | 63504 | 63505 | 63506 | 63674 | 63675 | 63734 | 63735 | 63736 | 63737 | 63738 | 63983 | 63984 | 63985