Attachment 63689 Details for Bug 18226 – Bug 18226: [QA Follow-up] Remove verbose

[patch] Bug 18226: [QA Follow-up] Remove verbose

Bug-18226-QA-Follow-up-Remove-verbose.patch (text/plain), 1.49 KB, created by Marcel de Rooy on 2017-05-24 12:18:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-05-24 12:18:17 UTC

Size: 1.49 KB

patch

obsolete

>From 840b21883e55e11052a3ff851bfbfaffbaf0b408 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 24 May 2017 14:14:50 +0200
>Subject: [PATCH] Bug 18226: [QA Follow-up] Remove verbose
>Content-Type: text/plain; charset=utf-8
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/01-test_dbic.t | 6 ------
> 1 file changed, 6 deletions(-)
>
>diff --git a/t/db_dependent/01-test_dbic.t b/t/db_dependent/01-test_dbic.t
>index 0312120..0731a99 100644
>--- a/t/db_dependent/01-test_dbic.t
>+++ b/t/db_dependent/01-test_dbic.t
>@@ -10,8 +10,6 @@ use Test::MockModule;
> use Koha::Database;
> use Koha::Libraries;
> 
>-my $verbose = 0;
>-
> subtest "Scenario: Show how caching prevents Test::DBIx::Class from working properly and how to circumvent it", sub {
>   my ($firstSchema, $cachedSchema, $cachedSchema2, $firstLibCount, $libCount);
> 
>@@ -22,15 +20,11 @@ subtest "Scenario: Show how caching prevents Test::DBIx::Class from working prop
> 
>   $firstLibCount = Koha::Libraries->search->count; # first count normal conn
> 
>-  print "\$firstLibCount '$firstLibCount'\n" if $verbose;
>-
>   ok($cachedSchema = Koha::Database::get_schema_cached(),
>   '  And the DB connection is cached');
> 
>   unlike(getConnectionDBName($cachedSchema), qr/sqlite/i,
>   '  And the cached DB connection type is not sqlite');
>-  print "getConnectionDBName() -> ".getConnectionDBName($cachedSchema)."\n" if $verbose;
>-
> 
>   use_ok('Test::DBIx::Class');
>   my $db = Test::MockModule->new('Koha::Database');
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18226: 60885 | 60886 | 60920 | 60923 | 62960 | 62961 | 62962 | 62968 | 62969 | 62970 | 63688 | 63689 | 63999 | 64008 | 64009 | 64010 | 64011 | 64012 | 64013