Attachment 63752 Details for Bug 1985 – Bug 1985: perltidy Koha/Review.pm

[patch] Bug 1985: perltidy Koha/Review.pm

Bug-1985-perltidy-KohaReviewpm.patch (text/plain), 2.32 KB, created by Mark Tompsett on 2017-05-26 17:51:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mark Tompsett

Created: 2017-05-26 17:51:59 UTC

Size: 2.32 KB

patch

obsolete

>From ebb0bf9c12443d73241bc3502a83d7f8eb23e477 Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Fri, 26 May 2017 13:44:26 -0400
>Subject: [PATCH] Bug 1985: perltidy Koha/Review.pm
>
>---
> Koha/Review.pm | 32 +++++++++++++++++---------------
> 1 file changed, 17 insertions(+), 15 deletions(-)
>
>diff --git a/Koha/Review.pm b/Koha/Review.pm
>index 97fa682..b031215 100644
>--- a/Koha/Review.pm
>+++ b/Koha/Review.pm
>@@ -43,7 +43,7 @@ Approve a review
> =cut
> 
> sub approve {
>-    my ( $self ) = @_;
>+    my ($self) = @_;
>     $self->approved(1)->store;
> }
> 
>@@ -56,7 +56,7 @@ Unapprove a review
> =cut
> 
> sub unapprove {
>-    my ( $self ) = @_;
>+    my ($self) = @_;
>     $self->approved(0)->store;
> }
> 
>@@ -81,36 +81,38 @@ sub send_review_alert {
>     my ( $self, $params ) = @_;
> 
>     my $borrowernumber = $params->{borrowernumber};
>-    my $reviewid = $params->{reviewid};
>-    my $biblionumber = $params->{biblionumber};
>+    my $reviewid       = $params->{reviewid};
>+    my $biblionumber   = $params->{biblionumber};
> 
>     my $moderator_email = C4::Context->preference('CommentModeratorsEmail');
>-    if (!$moderator_email) {
>+    if ( !$moderator_email ) {
>         carp 'CommentModeratorsEmail is not set!';
>         return;
>     }
> 
>-    my $letter =  C4::Letters::GetPreparedLetter (
>-        module => 'members',
>+    my $letter = C4::Letters::GetPreparedLetter(
>+        module      => 'members',
>         letter_code => 'COMMENT_CREATED',
>-        tables => {
>+        tables      => {
>             'reviews'     => $reviewid,
>             'borrowers'   => $borrowernumber,
>             'biblio'      => $biblionumber,
>             'biblioitems' => $biblionumber,
>         }
>     );
>-    if (!$letter) {
>+    if ( !$letter ) {
>         carp 'COMMENT_CREATED member letter not found!';
>         return;
>     }
> 
>-    C4::Letters::EnqueueLetter({
>-        letter                 => $letter,
>-        borrowernumber         => $borrowernumber,
>-        message_transport_type => 'email',
>-        to_address             => $moderator_email,
>-    });
>+    C4::Letters::EnqueueLetter(
>+        {
>+            letter                 => $letter,
>+            borrowernumber         => $borrowernumber,
>+            message_transport_type => 'email',
>+            to_address             => $moderator_email,
>+        }
>+    );
> 
>     return 1;
> }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 1985: 33916 | 33918 | 36065 | 36516 | 36517 | 36521 | 36522 | 36613 | 36614 | 36628 | 36629 | 36643 | 36644 | 36645 | 36677 | 36678 | 36720 | 38908 | 38909 | 38910 | 39062 | 63746 | 63747 | 63748 | 63749 | 63750 | 63751 | 63752 | 63761 | 63762 | 63763 | 74760 | 74761 | 74762 | 74763 | 74764 | 74769 | 74770 | 74771 | 91190 | 91191 | 91192 | 91193 | 91194 | 91195 | 91196 | 91197 | 91198 | 91818 | 91819 | 91820 | 91821 | 91822 | 91823