Attachment 63814 Details for Bug 18692 – Bug 18692 - When SMS is enabled the OPAC messaging table is misaligned

[patch] Bug 18692 - When SMS is enabled the OPAC messaging table is misaligned

Bug-18692---When-SMS-is-enabled-the-OPAC-messaging.patch (text/plain), 3.70 KB, created by Fridolin Somers on 2017-05-29 14:38:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2017-05-29 14:38:57 UTC

Size: 3.70 KB

patch

obsolete

>From 0fdc90d2e07da3ccd1458c5f386831da0925e7ee Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 29 May 2017 16:32:18 +0200
>Subject: [PATCH] Bug 18692 - When SMS is enabled the OPAC messaging table is
> misaligned
>
>Bug 6726 had corrected the fact that when SMS is enabled the messaging table is missing a column.
>Bug 6458 has broken this.
>The SMS column is missing an else case with cell containing only "-" like other columns.
>
>Test plan :
>- set SMSSendDriver preference empty
>- go to OPAC patron messaging
>- column SMS should not be visible
>- set SMSSendDriver preference not empty
>- go to OPAC patron messaging
>- column SMS appears with checkboxes
>---
> .../opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 20 ++++++++++----------
> 1 file changed, 10 insertions(+), 10 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>index 84cb228..32d1416 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>@@ -63,16 +63,16 @@
>                                         [% ELSE %]
>                                             <td>-</td>
>                                         [% END %]
>-                                        [% IF ( messaging_preference.transport_sms ) %]
>-                                            [% IF ( SMSSendDriver ) %]
>-                                                <td>
>-                                                    [% IF ( messaging_preference.transports_sms ) %]
>-                                                      <input type="checkbox" id="sms[% messaging_preference.message_attribute_id %]" name="[% messaging_preference.message_attribute_id %]" value="sms" checked="checked" onclick = "document.opacmessaging.none[% messaging_preference.message_attribute_id %].checked=false;" />
>-                                                    [% ELSE %]
>-                                                        <input type="checkbox" id="sms[% messaging_preference.message_attribute_id %]" name="[% messaging_preference.message_attribute_id %]" value="sms" onclick = "document.opacmessaging.none[% messaging_preference.message_attribute_id %].checked=false;" />
>-                                                    [% END %]
>-                                                </td>
>-                                            [% END %]
>+                                        [% IF ( SMSSendDriver ) %]
>+                                            <td>
>+                                                [% IF ( messaging_preference.transports_sms ) %]
>+                                                    <input type="checkbox" id="sms[% messaging_preference.message_attribute_id %]" name="[% messaging_preference.message_attribute_id %]" value="sms" checked="checked" onclick = "document.opacmessaging.none[% messaging_preference.message_attribute_id %].checked=false;" />
>+                                                [% ELSE %]
>+                                                    <input type="checkbox" id="sms[% messaging_preference.message_attribute_id %]" name="[% messaging_preference.message_attribute_id %]" value="sms" onclick = "document.opacmessaging.none[% messaging_preference.message_attribute_id %].checked=false;" />
>+                                                [% END %]
>+                                            </td>
>+                                        [% ELSE %]
>+                                            <td>-</td>
>                                         [% END %]
>                                         [% IF ( TalkingTechItivaPhone ) %]
>                                             <td>
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 18692: 63814 | 63830 | 63872 | 63897 | 63898 | 63900 | 64409 | 64410 | 65170 | 65171 | 65451 | 65906 | 66731