Attachment 63856 Details for Bug 18704 – Bug 18704 - File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel

[patch] Bug 18704 - File types limit in tools/export.pl is causing issues with csv files generated by MS/Excel

Bug-18704---File-types-limit-in-toolsexportpl-is-c.patch (text/plain), 1.20 KB, created by Nick Clemens (kidclamp) on 2017-05-30 20:57:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2017-05-30 20:57:14 UTC

Size: 1.20 KB

patch

obsolete

>From af90034e6e3b00591d59f21bc2ebb95cff56e9b5 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 30 May 2017 16:55:19 -0400
>Subject: [PATCH] Bug 18704 - File types limit in tools/export.pl is causing
> issues with csv files generated by MS/Excel
>
>To test:
>1 - Save a csv of biblionumber from MS/Excel
>2 - Attempt to export records using this file
>3 - It fails (mimetype is appliction/vnd.ms-excel)
>4 - Apply patch
>5 - Try again
>6 - It succeeds!
>---
> tools/export.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/export.pl b/tools/export.pl
>index 0165cf1..208d7f4 100755
>--- a/tools/export.pl
>+++ b/tools/export.pl
>@@ -74,7 +74,7 @@ if ( $op eq 'export' ) {
>     my $filename = $query->param('id_list_file');
>     if ( $filename ) {
>         my $mimetype = $query->uploadInfo($filename)->{'Content-Type'};
>-        my @valid_mimetypes = qw( application/octet-stream text/csv text/plain );
>+        my @valid_mimetypes = qw( application/octet-stream text/csv text/plain application/vnd.ms-excel );
>         unless ( grep { /^$mimetype$/ } @valid_mimetypes ) {
>             push @messages, { type => 'alert', code => 'invalid_mimetype' };
>             $op = '';
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18704: 63856 | 63892 | 63932