Bugzilla – Attachment 6391 Details for
Bug 6022
Auth_with_ldap check if categorycode is valid
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6022: Auth_with_ldap check if categorycode is valid
Bug-6022-Authwithldap-check-if-categorycode-is-val.patch (text/plain), 1.71 KB, created by
Dobrica Pavlinusic
on 2011-11-24 14:53:46 UTC
(
hide
)
Description:
Bug 6022: Auth_with_ldap check if categorycode is valid
Filename:
MIME Type:
Creator:
Dobrica Pavlinusic
Created:
2011-11-24 14:53:46 UTC
Size:
1.71 KB
patch
obsolete
>From 36117afe8f022d7e3dc18b16e5e6852458a3d5cd Mon Sep 17 00:00:00 2001 >From: Dobrica Pavlinusic <dpavlin@rot13.org> >Date: Thu, 31 Mar 2011 15:14:46 +0200 >Subject: [PATCH] Bug 6022: Auth_with_ldap check if categorycode is valid > >When importing users from LDAP, Auth_with_ldap.pm doesn't check if value for >categorycode is present in categories table in Koha resulting in referential >integrity error instead of using default value from koha-conf.xml > >Test scenario: >1. enable LDAP in koha-conf.xml using <useldapserver>1</useldapserver> > and add <ldapserver> configuration with > <categorycode is="SomeLDAPField">DefaultCategoryCode</categorycode> >2. select/create LDAP user with category in SomeLDAPField which isn't in > Koha >3. try logging in and ensure that assigned category to new user is > DefaultCategoryCode >--- > C4/Auth_with_ldap.pm | 11 +++++++++++ > 1 files changed, 11 insertions(+), 0 deletions(-) > >diff --git a/C4/Auth_with_ldap.pm b/C4/Auth_with_ldap.pm >index 7f56d9c..6ecf509 100644 >--- a/C4/Auth_with_ldap.pm >+++ b/C4/Auth_with_ldap.pm >@@ -228,6 +228,17 @@ sub ldap_entry_2_hash ($$) { > ( substr($borrower{'firstname'},0,1) > . substr($borrower{ 'surname' },0,1) > . " "); >+ >+ # check if categorycode exists, if not, fallback to default from koha-conf.xml >+ my $dbh = C4::Context->dbh; >+ my $sth = $dbh->prepare("SELECT categorycode FROM categories WHERE categorycode = ?"); >+ $sth->execute( uc($borrower{'categorycode'}) ); >+ unless ( my $row = $sth->fetchrow_hashref ) { >+ my $default = $mapping{'categorycode'}->{content}; >+ $debug && warn "Can't find ", $borrower{'categorycode'}, " default to: $default for ", $borrower{userid}; >+ $borrower{'categorycode'} = $default >+ } >+ > return %borrower; > } > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6022
:
3572
|
4140
|
4985
|
6391
|
6392