Bugzilla – Attachment 63927 Details for
Bug 18717
Use of uninitialized value in string eq at C4/Acquisition.pm line 318 after bug 8612
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18717: Check existence of variables
Bug-18717-Check-existence-of-variables.patch (text/plain), 1.40 KB, created by
Josef Moravec
on 2017-06-02 09:04:35 UTC
(
hide
)
Description:
Bug 18717: Check existence of variables
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2017-06-02 09:04:35 UTC
Size:
1.40 KB
patch
obsolete
>From 14c7dd10648b15349e809a297bb12c6ce4d04ac4 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Fri, 2 Jun 2017 08:42:32 +0000 >Subject: [PATCH] Bug 18717: Check existence of variables > >Test plan: >0) Apply the patches from bug 8612 >1) Have basket with some orders - at least one biblio should NOT have >isbn filled >2) Define custom CSV profile of tpe SQL and Usage "Basket export in >acquisition" >2) Go to basket detail and download basket as CSV using this custom CSV profile >3) Read the log >--> without this patch you see the warning about uninitialized variables >--> with patch the warning shouldn't be logged >--- > C4/Acquisition.pm | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index ac5415b..98fdf6c 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -315,7 +315,10 @@ sub GetBasketAsCSV { > my $bd = GetBiblioData( $order->{'biblionumber'} ); > my @biblioitems = GetBiblioItemByBiblioNumber( $order->{'biblionumber'}); > for my $biblioitem (@biblioitems) { >- if ($biblioitem->{isbn} eq $order->{isbn}) { >+ if (defined $biblioitem->{isbn} >+ && defined $order->{isbn} >+ && $biblioitem->{isbn} eq $order->{isbn} >+ ) { > $order = {%$order, %$biblioitem}; > } > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18717
: 63927