Bugzilla – Attachment 63945 Details for
Bug 18716
CGI::param in list context warns in updatesupplier.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18716: Remove CGI::param warns from updatesupplier.pl
Bug-18716-Remove-CGIparam-warns-from-updatesupplie.patch (text/plain), 1.47 KB, created by
Marc Véron
on 2017-06-02 17:28:14 UTC
(
hide
)
Description:
Bug 18716: Remove CGI::param warns from updatesupplier.pl
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2017-06-02 17:28:14 UTC
Size:
1.47 KB
patch
obsolete
>From b86e51eecc701f00a3bdbc1635cdd8b4406dfe1c Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Thu, 1 Jun 2017 23:52:07 -0300 >Subject: [PATCH] Bug 18716: Remove CGI::param warns from updatesupplier.pl >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This script floods the logs with this kind of warnings. > >To test: >- Run: > $ koha-plack-err >- Edit a vendor in the acquisitions module >- Save >=> FAIL: Logs show lots of warnings that look like: > CGI::param called in list context from package CGI::Compile::ROOT::home_vagrant_kohaclone_acqui_updatesupplier_2epl >- Apply this patch >- Run: > $ restart_all > $ koha-plack-err >- Edit a vendor, add/delete vendor contacts >=> SUCESS: No more warnings >- Verify editing and storing vendor contacts works as expected. >- Sign off :-D > >Signed-off-by: Marc Véron <veron@veron.ch> >--- > acqui/updatesupplier.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/acqui/updatesupplier.pl b/acqui/updatesupplier.pl >index 822d7a0..18912dd 100755 >--- a/acqui/updatesupplier.pl >+++ b/acqui/updatesupplier.pl >@@ -99,7 +99,7 @@ my @contacts; > my %contact_info; > > foreach (qw(id name position phone altphone fax email notes orderacquisition claimacquisition claimissues acqprimary serialsprimary)) { >- $contact_info{$_} = [ $input->param('contact_' . $_) ]; >+ $contact_info{$_} = [ $input->multi_param('contact_' . $_) ]; > } > > for my $cnt (0..scalar(@{$contact_info{'id'}})) { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18716
:
63901
|
63945
|
64147