Bugzilla – Attachment 63985 Details for
Bug 18478
Some notices sent via SMS gateway fail
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[16.11.x rebase] Bug 18478 - QA Followup
1611x-rebase-Bug-18478---QA-Followup.patch (text/plain), 1.24 KB, created by
Nick Clemens (kidclamp)
on 2017-06-05 18:45:08 UTC
(
hide
)
Description:
[16.11.x rebase] Bug 18478 - QA Followup
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-06-05 18:45:08 UTC
Size:
1.24 KB
patch
obsolete
>From b6c8015ab3d6e69963b7c91f516c4fa1e42fc6e4 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Tue, 23 May 2017 16:11:06 -0400 >Subject: [PATCH] [16.11.x rebase] Bug 18478 - QA Followup > >Make sure to build necessary letters >Fix awkward construction > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > C4/Letters.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index c53c63e..07ef1f7 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -1052,7 +1052,7 @@ sub SendQueuedMessages { > _set_message_status( { message_id => $message->{'message_id'}, status => 'failed' } ); > next MESSAGE; > } >- $message->{to_address} = $message->{to_address} ? $message->{to_address} : $member->{'smsalertnumber'}; >+ $message->{to_address} ||= $member->{'smsalertnumber'}; > unless ( $message->{to_address} && $member->{'smsalertnumber'} ) { > _set_message_status( { message_id => $message->{'message_id'}, status => 'failed' } ); > warn sprintf( "No smsalertnumber found for patron %s!", $message->{'borrowernumber'} ) if $params->{'verbose'} or $debug; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18478
:
63487
|
63488
|
63504
|
63505
|
63506
|
63674
|
63675
|
63734
|
63735
|
63736
|
63737
|
63738
|
63983
|
63984
| 63985