Bugzilla – Attachment 63988 Details for
Bug 18702
Translatability: Get rid of exposed if statement in tt for translated onboardingstep2.tt
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18702: Translatability: Get rid of exposed if statement in tt for translated onboardingstep2.tt
Bug-18702-Translatability-Get-rid-of-exposed-if-st.patch (text/plain), 2.79 KB, created by
Jonathan Druart
on 2017-06-05 20:01:57 UTC
(
hide
)
Description:
Bug 18702: Translatability: Get rid of exposed if statement in tt for translated onboardingstep2.tt
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-06-05 20:01:57 UTC
Size:
2.79 KB
patch
obsolete
>From 17fd5a4ffb6fa92e1ce522ac8f8cf5fdeb343868 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Tue, 30 May 2017 18:50:16 +0200 >Subject: [PATCH] Bug 18702: Translatability: Get rid of exposed if statement > in tt for translated onboardingstep2.tt > >The file onboardingstep2.tt exposes the following to translations: > >"[%% IF (categories && categories.count > 1 ) # This if statement checks if " >"the categories variable handed to this template # by onboarding.pl has data " >"in it. If the categories variable does have data # in it this means that the " >"user has previously imported sample patron category # data and so we do not " >"need to show them the create patron category screen 1, #instead we can " >"display a screen with ubtton redirecting the user to step 3 %%] " > >Translators should not be confronted with such internals. This patch removes it > >To test: >- Verify that code change makes sense >- Run QA tools >- Bonus test: Create a new "language" aa-AA and verify that the lines above > are no longer exposed. > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > .../prog/en/modules/onboarding/onboardingstep2.tt | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt >index e58616aa75..45e5f3dea8 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep2.tt >@@ -2,12 +2,12 @@ > [% USE KohaDates %] > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › Web installer › Add a patron category</title> >-[% IF (categories && categories.count > 1 ) >- # This if statement checks if the categories variable handed to this template >- # by onboarding.pl has data in it. If the categories variable does have data >- # in it this means that the user has previously imported sample patron category >- # data and so we do not need to show them the create patron category screen 1, >- #instead we can display a screen with ubtton redirecting the user to step 3 %] >+[%# The following if statement checks if the categories variable handed to this template %] >+[%# by onboarding.pl has data in it. If the categories variable does have data %] >+[%# in it this means that the user has previously imported sample patron category %] >+[%# data and so we do not need to show them the create patron category screen 1, %] >+[%#instead we can display a screen with ubtton redirecting the user to step 3 %] >+[% IF (categories && categories.count > 1 ) %] > <meta http-equiv="refresh" content="0; url=/cgi-bin/koha/installer/onboarding.pl?step=3"> > [% END %] > [% INCLUDE 'installer-doc-head-close.inc' %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18702
:
63850
| 63988