Bugzilla – Attachment 64006 Details for
Bug 18286
Test::DBIx::Class connection/schema is shadowed by a cached connection/schema
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18286: [QA Follow-up] Fix some warnings from qa tools
Bug-18286-QA-Follow-up-Fix-some-warnings-from-qa-t.patch (text/plain), 1.99 KB, created by
Jonathan Druart
on 2017-06-05 20:53:45 UTC
(
hide
)
Description:
Bug 18286: [QA Follow-up] Fix some warnings from qa tools
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-06-05 20:53:45 UTC
Size:
1.99 KB
patch
obsolete
>From ef73dac64ac334ec091d1345bb407cbefae8fe03 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Tue, 2 May 2017 15:46:08 +0200 >Subject: [PATCH] Bug 18286: [QA Follow-up] Fix some warnings from qa tools > >[1] Resolve warning on variable assignment before use strict. >[2] Remove unused $schema variable. >[3] Remove eval expression construction. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/01-test_dbic.t | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > >diff --git a/t/db_dependent/01-test_dbic.t b/t/db_dependent/01-test_dbic.t >index 9f63d20218..0741332b51 100644 >--- a/t/db_dependent/01-test_dbic.t >+++ b/t/db_dependent/01-test_dbic.t >@@ -1,7 +1,6 @@ > #!/usr/bin/perl > > # This file is part of Koha. >-my $verbose = 0; > > use Modern::Perl; > >@@ -10,12 +9,14 @@ use Test::MockModule; > > use Koha::Libraries; > use C4::Context; >+ > Koha::Libraries->search->count; > >+my $verbose = 0; > > > subtest "Scenario: Show how caching prevents Test::DBIx::Class from working properly and how to circumvent it", sub { >- my ($firstSchema, $schema, $cachedSchema, $cachedSchema2, $firstLibCount, $libCount); >+ my ($firstSchema, $cachedSchema, $cachedSchema2, $firstLibCount, $libCount); > > eval { > >@@ -74,13 +75,13 @@ subtest "Scenario: Show how caching prevents Test::DBIx::Class from working prop > ' And the cached DB connection type is sqlite'); > > >- eval "fixtures_ok [ #Dynamically load fixtures, because we dynamically load T:D:C. Otherwise there be compile errors! >+ fixtures_ok( [ #Dynamically load fixtures, because we dynamically load T:D:C. Otherwise there be compile errors! > Branch => [ > ['branchcode', 'branchname'], > ['XXX_test', 'my branchname XXX'], > ] > ], >- 'Step: Given we deploy T:D:C Fixtures';"; >+ 'Step: Given we deploy T:D:C Fixtures'); > > ok($libCount = Koha::Libraries->search->count, > ' When the libraries are counted'); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18286
:
61186
|
62963
|
62964
|
62965
|
62966
|
64004
|
64005
| 64006 |
64007