Attachment 64018 Details for Bug 18728 – [SIGNED-OFF] Bug 18728 - use html filter in suggestions datatable sort

[patch] [SIGNED-OFF] Bug 18728 - use html filter in suggestions datatable sort

SIGNED-OFF-Bug-18728---use-html-filter-in-suggesti.patch (text/plain), 2.11 KB, created by Josef Moravec on 2017-06-06 04:21:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2017-06-06 04:21:38 UTC

Size: 2.11 KB

patch

obsolete

>From a7890809d9eb4a63a6a4f750b3ebb49042452306 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 5 Jun 2017 13:52:01 +0200
>Subject: [PATCH] [SIGNED-OFF] Bug 18728 - use html filter in suggestions
> datatable sort
>
>In suggestions datatable one can sort on colums "Suggested by" or "Managed by".
>Those columns may contain HTML tags.
>Use datatable sorting type html to have a correct sorting.
>
>Test plan :
>- Be sure to have some suggestions asked and managed
>- Go to Acquisitions > Suggestions
>- Click on "Suggested by" to sort
>=> Table is sorted by the user name
>- Click on "Managed by" to sort
>=> Table is sorted by the user name
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>index 62335e8..f7eb4e2 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
>@@ -54,7 +54,8 @@ $(document).ready(function() {
>     $(".sorted").dataTable($.extend(true, {}, dataTablesDefaults, {
>         "aoColumnDefs": [
>             { "aTargets": [ 0 ], "bSortable": false, "bSearchable": false },
>-            { "sType": "anti-the", "aTargets" : [ "anti-the" ] }
>+            { "sType": "anti-the", "aTargets" : [ "anti-the" ] },
>+            { "sType": "html", "aTargets" : [ "stype-html" ] },
>         ],
>         "sPaginationType": "four_button"
>     }));
>@@ -528,8 +529,8 @@ h4.local_collapse a { font-size : 80%; text-decoration: none; } fieldset.brief o
>             <tr><th>&nbsp;</th>
>             <th>No.</th>
>             <th class="anti-the">Suggestion</th>
>-            <th>Suggested by - on</th>
>-            <th>Managed by - on</th>
>+            <th class="stype-html">Suggested by - on</th>
>+            <th class="stype-html">Managed by - on</th>
>             <th>Library</th>
>             <th>Fund</th>
>             <th>Status</th></tr>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18728: 63960 | 64018