Bugzilla – Attachment 64135 Details for
Bug 18766
ArticleRequests.t raises warnings
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18766: Remove itemtype-related warnings from ArticleRequests.t
Bug-18766-Remove-itemtype-related-warnings-from-Ar.patch (text/plain), 1.26 KB, created by
Jonathan Druart
on 2017-06-09 13:53:17 UTC
(
hide
)
Description:
Bug 18766: Remove itemtype-related warnings from ArticleRequests.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-06-09 13:53:17 UTC
Size:
1.26 KB
patch
obsolete
>From e426da4e009ce63c10923eaddd1ca271dca8005e Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Fri, 9 Jun 2017 10:46:49 -0300 >Subject: [PATCH] Bug 18766: Remove itemtype-related warnings from > ArticleRequests.t > >This patch fixes a small mistake on that test file (itype vs. itemtype >in itemtypes table) > >To test: >- Run: > $ sudo koha-shell kohadev > k$ cd kohaclone > k$ prove t/db_dependent/ArticleRequests.t >=> FAIL: itemtype-related warning displayed >- Apply the patch >- Run > k$ prove t/db_dependent/ArticleRequests.t >=> SUCCESS: No warnings, YAY! >- Sign off :-D > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/ArticleRequests.t | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/t/db_dependent/ArticleRequests.t b/t/db_dependent/ArticleRequests.t >index 482cce2..a9466a6 100755 >--- a/t/db_dependent/ArticleRequests.t >+++ b/t/db_dependent/ArticleRequests.t >@@ -58,7 +58,7 @@ my $item = Koha::Item->new( > { > biblionumber => $biblio->id, > biblioitemnumber => $biblioitem->id, >- itype => $itype->{itype}, >+ itype => $itype->{itemtype}, > } > )->store(); > ok( $item->id, 'Koha::Item created' ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18766
:
64134
| 64135