Attachment 64144 Details for Bug 18727 – Bug 18727: System preferences loose part of values because of double quotes

[patch] Bug 18727: System preferences loose part of values because of double quotes

Bug-18727-System-preferences-loose-part-of-values-.patch (text/plain), 4.03 KB, created by Jonathan Druart on 2017-06-09 14:53:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-06-09 14:53:19 UTC

Size: 4.03 KB

patch

obsolete

>From 6e7c125a56be8971ec9c9bb52373bff5004a936a Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch>
>Date: Mon, 5 Jun 2017 06:52:58 +0200
>Subject: [PATCH] Bug 18727: System preferences loose part of values because of
> double quotes
>
>System preferences do not display values of text fields properly if they
>contain doulbe quotes.
>
>To recreate:
>- Go to Home > Administration > System preferences , then tab Acquisitions
>- Enter values to both system preferences like proposed in the example (o=5|a="bar foo" and  o=5|a="foo bar")
>- Save
>- Click on tab Acquisitions to reload
>- Wrong result: Both preferences show a value of: o=5|a=
>  (parts with double quotes are truncated)
>
>- Edit any of the email addresses (Bug 9814):
>  KohaAdminEmailAddress, NoticeBcc, ReplytoDefault, PayPalUser
>- Set value to: "The Library" <thelibrary@example.com>
>- Search for this email address syspref to re-display it
>- Wrong result:
>  Use [     ] " autocomplete="off" /> as the email address for the
>  administrator of Koha.
>
>To test:
>- Apply patch
>- Try to recreate issues above
>- Additionally, edit other system preferences that could contain double
>  quotes, e.g. LibraryName or UsageStatsLibraryName
>- Set value to: Bibliothek "Zur Leseratte"
>
>(Note: patch contains a tiny fix for a typo in acquisitions.pref)
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt            | 2 +-
> .../intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref   | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>index 22fb0011ca..28ccddcff0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>@@ -122,7 +122,7 @@
>                     [% IF ( CHUNK.type_text ) %]
>                     [% CHUNK.contents %]
>                     [% ELSIF ( CHUNK.type_input ) %]
>-                    <input type="[%IF CHUNK.input_type %][% CHUNK.input_type %][% ELSE %]text[% END %]" name="pref_[% CHUNK.name %]" id="pref_[% CHUNK.name %]" class="preference preference-[% CHUNK.class or "short" %]" value="[% CHUNK.value %]" autocomplete="off" /> [% IF ( CHUNK.dateinput ) %]<span class="hint">[% INCLUDE 'date-format.inc' %]</span>[% END %]
>+                    <input type="[%IF CHUNK.input_type %][% CHUNK.input_type %][% ELSE %]text[% END %]" name="pref_[% CHUNK.name %]" id="pref_[% CHUNK.name %]" class="preference preference-[% CHUNK.class or "short" %]" value="[% CHUNK.value| html %]" autocomplete="off" /> [% IF ( CHUNK.dateinput ) %]<span class="hint">[% INCLUDE 'date-format.inc' %]</span>[% END %]
>                     [% ELSIF ( CHUNK.type_select ) %]
>                     <select name="pref_[% CHUNK.name %]" id="pref_[% CHUNK.name %]" class="preference preference-[% CHUNK.class or "choice" %]">
>                         [% FOREACH CHOICE IN CHUNK.CHOICES.sort('value') %]
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
>index cf23628ac2..41bd29d671 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref
>@@ -48,7 +48,7 @@ Acquisitions:
>             - Upon receiving items, update their subfields if they were created when placing an order (e.g. o=5|a="foo bar").
>             - pref: AcqItemSetSubfieldsWhenReceived
>         -
>-            - Upon cancelling a receipt, update the item's subfields if they were created when placing an order (e.g. o=5|a="bar foo"").
>+            - Upon cancelling a receipt, update the item's subfields if they were created when placing an order (e.g. o=5|a="bar foo").
>             - pref: AcqItemSetSubfieldsWhenReceiptIsCancelled
>         -
>             - pref: AcqEnableFiles
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 18727: 63956 | 63958 | 64144