Attachment 64153 Details for Bug 18706 – Bug 18706 - Remove useless Javascript

[patch] Bug 18706 - Remove useless Javascript

Bug-18706---Remove-useless-Javascript.patch (text/plain), 1.38 KB, created by Jonathan Druart on 2017-06-09 15:28:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-06-09 15:28:10 UTC

Size: 1.38 KB

patch

obsolete

>From 6bb4a0405abe0d03be3915644c6a05e2e3ee1e9f Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Wed, 31 May 2017 16:10:41 +0200
>Subject: [PATCH] Bug 18706 - Remove useless Javascript
>
>Whe checking a subfield to be deleted, the code
>  $(this).val($(this).siblings("[name='subfield']").val());
>is useless, the checkbox already contains the subfield code :
>  <input type="checkbox" ... name="disable_input" value="[% ite.subfield %]" />
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>index e774e95bae..2b746ab403 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/batchMod-edit.tt
>@@ -24,7 +24,6 @@ $(document).ready(function(){
>       row = row.replace("row","hint");
>       var editor = $(this).parent().find("[name='field_value']");
>       if ($(this).is(":checked")) {
>-          $(this).val($(this).siblings("[name='subfield']").val());
>           $(editor).prop('disabled', true);
>           $("#"+row).html(_("This subfield will be deleted"));
>       } else {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 18706: 63864 | 63865 | 63890 | 63891 | 64152 | 64153