Attachment 64262 Details for Bug 18749 – Bug 18749 - xt/sample_notices.t fails

[patch] Bug 18749 - xt/sample_notices.t fails

Bug-18749---xtsamplenoticest-fails.patch (text/plain), 1.52 KB, created by Jonathan Druart on 2017-06-13 15:38:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2017-06-13 15:38:16 UTC

Size: 1.52 KB

patch

obsolete

>From 323cc1501fc91d67e8ecaa0a2cdf272f642d8e46 Mon Sep 17 00:00:00 2001
>From: Lee Jamison <ldjamison@marywood.edu>
>Date: Wed, 7 Jun 2017 11:34:29 +0000
>Subject: [PATCH] Bug 18749 - xt/sample_notices.t fails
>
>Bug Description:
>When performing a unit test on xt/sample_notices.t with the command
>'prove xt/sample_notices.t' 11 tests fail with the error message
>"No sample notice to delete".
>
>Cause of bug:
>The failures are caused by an incorrect file path on Line 25 of
>xt/sample_notices.t.
>
>Patch Description:
>This patch corrects the failures by changing $base_notices_file from
>"en/default/sample_notices.sql" to "en/mandatory/sample_notices.sql"
>
>Test Plan:
>1) Drop into koha-shell and run the command 'prove xt/sample_notices.'
>2) 11 unit tests fail.
>3) Apply the patch.
>4) Re-run 'prove xt/sample_notices.t'
>5) All of the tests pass now.
>6) Quit out of koha-shell
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> xt/sample_notices.t | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/xt/sample_notices.t b/xt/sample_notices.t
>index 39e3ab20cc..26534077ea 100755
>--- a/xt/sample_notices.t
>+++ b/xt/sample_notices.t
>@@ -22,7 +22,7 @@ use Test::More qw(no_plan);
> 
> 
> my $root_dir = 'installer/data/mysql';
>-my $base_notices_file = "en/default/sample_notices.sql";
>+my $base_notices_file = "en/mandatory/sample_notices.sql";
> my @trans_notices_files = qw(
>     fr-FR/1-Obligatoire/sample_notices.sql
>     fr-CA/obligatoire/sample_notices.sql
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 18749: 64086 | 64180 | 64262