Bugzilla – Attachment 6428 Details for
Bug 6629
[security] insecure use of Cookie for language selection
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6629 : Follow up, sanitising in a couple more places
Bug-6629--Follow-up-sanitising-in-a-couple-more-pl.patch (text/plain), 1.33 KB, created by
Chris Cormack
on 2011-11-27 09:01:26 UTC
(
hide
)
Description:
Bug 6629 : Follow up, sanitising in a couple more places
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2011-11-27 09:01:26 UTC
Size:
1.33 KB
patch
obsolete
>From 5adab6881dcac152b662619998880b5992b410ca Mon Sep 17 00:00:00 2001 >From: Chris Cormack <chrisc@catalyst.net.nz> >Date: Sun, 27 Nov 2011 21:58:04 +1300 >Subject: [PATCH] Bug 6629 : Follow up, sanitising in a couple more places > >--- > installer/install.pl | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > >diff --git a/installer/install.pl b/installer/install.pl >index 5b065e8..ae478b6 100755 >--- a/installer/install.pl >+++ b/installer/install.pl >@@ -229,6 +229,7 @@ elsif ( $step && $step == 3 ) { > # Framework Selection is achieved through checking boxes. > my $langchoice = $query->param('fwklanguage'); > $langchoice = $query->cookie('KohaOpacLanguage') unless ($langchoice); >+ $langchoice =~ s/[^a-zA-Z_-]*//g; > my $marcflavour = $query->param('marcflavour'); > if ($marcflavour){ > $installer->set_marcflavour_syspref($marcflavour); >@@ -266,6 +267,7 @@ elsif ( $step && $step == 3 ) { > # Marcflavour Selection is achieved through radiobuttons. > my $langchoice = $query->param('fwklanguage'); > $langchoice = $query->cookie('KohaOpacLanguage') unless ($langchoice); >+ $langchoice =~ s/[^a-zA-Z_-]*//g; > my $dir = > C4::Context->config('intranetdir') . "/installer/data/$info{dbms}/$langchoice/marcflavour"; > unless (opendir( MYDIR, $dir )) { >-- >1.7.5.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6629
:
6398
|
6399
|
6400
|
6401
|
6402
|
6403
|
6404
|
6405
|
6406
|
6411
|
6412
|
6422
|
6423
|
6424
|
6427
|
6428
|
6432