Bugzilla – Attachment 64312 Details for
Bug 18748
Noisy t/db_dependent/AuthorisedValues.t
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18748: Noisy t/db_dependent/AuthorisedValues.t
Bug-18748-Noisy-tdbdependentAuthorisedValuest.patch (text/plain), 1.85 KB, created by
Mark Tompsett
on 2017-06-15 12:20:26 UTC
(
hide
)
Description:
Bug 18748: Noisy t/db_dependent/AuthorisedValues.t
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-06-15 12:20:26 UTC
Size:
1.85 KB
patch
obsolete
>From 769dd692ca0e27adfc536d87112d5b2a82c9bf3b Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Wed, 7 Jun 2017 12:53:52 -0400 >Subject: [PATCH] Bug 18748: Noisy t/db_dependent/AuthorisedValues.t > >This noise is from a failure. This patch expands the delete >to 952$c for the ACQ framework as per comment #5. > >TEST PLAN >--------- > >insert into marc_subfield_structure (tagfield,tagsubfield,liblibrarian, libopac, repeatable, mandatory, kohafield,tab,authorised_value,authtypecode,value_builder,isurl,hidden,frameworkcode,seealso,link,defaultvalue,maxlength) values (952,'c','Shelving location','Shelving location',0,0,'items.location',10,'LOC','','',0,0,'ACQ','','',null,9999); >-- this makes sure you have a pre-existing 952$c ACQ record. > >prove t/db_dependent/AuthorisedValues.t >-- should have ugly message like in comment #0 >apply patch >prove t/db_dependent/AuthorisedValues.t >-- should be green >run koha qa test tools >--- > t/db_dependent/AuthorisedValues.t | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/t/db_dependent/AuthorisedValues.t b/t/db_dependent/AuthorisedValues.t >index ad5ec60..f7da7a5 100644 >--- a/t/db_dependent/AuthorisedValues.t >+++ b/t/db_dependent/AuthorisedValues.t >@@ -124,6 +124,8 @@ subtest 'search_by_*_field + find_by_koha_field + get_description' => sub { > $loc_cat->delete if $loc_cat; > my $mss = Koha::MarcSubfieldStructures->search( { tagfield => 952, tagsubfield => 'c', frameworkcode => '' } ); > $mss->delete if $mss; >+ $mss = Koha::MarcSubfieldStructures->search( { tagfield => 952, tagsubfield => 'c', frameworkcode => 'ACQ' } ); >+ $mss->delete if $mss; > $mss = Koha::MarcSubfieldStructures->search( { tagfield => 952, tagsubfield => 'd', frameworkcode => '' } ); > $mss->delete if $mss; > $mss = Koha::MarcSubfieldStructures->search( { tagfield => 952, tagsubfield => '5', frameworkcode => '' } ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18748
:
64084
|
64112
|
64312
|
64433
|
65047