Attachment 64331 Details for Bug 17738 – Bug 17738: Remove C4::Reserves::GetReservesFromBorrowernumber

[patch] Bug 17738: Remove C4::Reserves::GetReservesFromBorrowernumber

Bug-17738-Remove-C4ReservesGetReservesFromBorrower.patch (text/plain), 1.93 KB, created by Kyle M Hall (khall) on 2017-06-15 14:42:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2017-06-15 14:42:40 UTC

Size: 1.93 KB

patch

obsolete

>From f3b2de7bb2582fe15bd6de36347e4b47f861a488 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 7 Dec 2016 14:43:43 +0100
>Subject: [PATCH] Bug 17738: Remove C4::Reserves::GetReservesFromBorrowernumber
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>At this point, there should not be any occurrences of
>GetReservesFromBorrowernumber anymore.
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> C4/Reserves.pm | 35 -----------------------------------
> 1 file changed, 35 deletions(-)
>
>diff --git a/C4/Reserves.pm b/C4/Reserves.pm
>index 7e24ff4..79f5aea 100644
>--- a/C4/Reserves.pm
>+++ b/C4/Reserves.pm
>@@ -104,7 +104,6 @@ BEGIN {
>         &AddReserve
> 
>         &GetReserve
>-        &GetReservesFromBorrowernumber
>         &GetReservesForBranch
>         &GetReservesToBranch
>         &GetReserveCount
>@@ -279,40 +278,6 @@ sub GetReserve {
>     return $sth->fetchrow_hashref();
> }
> 
>-=head2 GetReservesFromBorrowernumber
>-
>-    $borrowerreserv = GetReservesFromBorrowernumber($borrowernumber,$tatus);
>-
>-TODO :: Descritpion
>-
>-=cut
>-
>-sub GetReservesFromBorrowernumber {
>-    my ( $borrowernumber, $status ) = @_;
>-    my $dbh   = C4::Context->dbh;
>-    my $sth;
>-    if ($status) {
>-        $sth = $dbh->prepare("
>-            SELECT *
>-            FROM   reserves
>-            WHERE  borrowernumber=?
>-                AND found =?
>-            ORDER BY reservedate
>-        ");
>-        $sth->execute($borrowernumber,$status);
>-    } else {
>-        $sth = $dbh->prepare("
>-            SELECT *
>-            FROM   reserves
>-            WHERE  borrowernumber=?
>-            ORDER BY reservedate
>-        ");
>-        $sth->execute($borrowernumber);
>-    }
>-    my $data = $sth->fetchall_arrayref({});
>-    return @$data;
>-}
>-
> =head2 CanBookBeReserved
> 
>   $canReserve = &CanBookBeReserved($borrowernumber, $biblionumber)
>-- 
>2.10.2

Actions: View | Diff | Splinter Review

Attachments on bug 17738: 58020 | 58021 | 62109 | 62110 | 62188 | 62189 | 62208 | 62219 | 64330 | 64331 | 64332 | 64749 | 64750 | 64751 | 64752