Bugzilla – Attachment 64349 Details for
Bug 18361
Koha::Objects->find should accept composite primary keys
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18361: (QA followup) Add tests for the no params case
Bug-18361-QA-followup-Add-tests-for-the-no-params-.patch (text/plain), 1.35 KB, created by
Jonathan Druart
on 2017-06-15 18:32:08 UTC
(
hide
)
Description:
Bug 18361: (QA followup) Add tests for the no params case
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-06-15 18:32:08 UTC
Size:
1.35 KB
patch
obsolete
>From 77b7fda54df620e230e3da1f3baee0ee615f8e4b Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Wed, 19 Apr 2017 11:57:33 -0300 >Subject: [PATCH] Bug 18361: (QA followup) Add tests for the no params case > >This patch adds a test for the trivial case in which no param is passed >and the ->find method returns undef. > >For completeness purposes. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > t/db_dependent/Koha/Objects.t | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Objects.t b/t/db_dependent/Koha/Objects.t >index 26125113b1..0f5926de76 100644 >--- a/t/db_dependent/Koha/Objects.t >+++ b/t/db_dependent/Koha/Objects.t >@@ -110,7 +110,7 @@ subtest 'new' => sub { > }; > > subtest 'find' => sub { >- plan tests => 4; >+ plan tests => 5; > > # check find on a single PK > my $patron = $builder->build({ source => 'Borrower' }); >@@ -133,6 +133,8 @@ subtest 'find' => sub { > my @pk = ( $rule->{branchcode}, $rule->{categorycode}, $rule->{itemtype} ); > is( ref(Koha::IssuingRules->find(@pk)), "Koha::IssuingRule", > 'Find returned a Koha object for composite primary key' ); >+ >+ is( Koha::Patrons->find(), undef, 'Find returns undef if no params passed' ); > }; > > subtest 'search_related' => sub { >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18361
:
61754
|
62142
|
62143
|
62395
|
62396
|
62397
|
62909
|
62910
|
62911
|
64339
|
64340
|
64341
|
64347
|
64348
| 64349 |
64372
|
66006