Bugzilla – Attachment 64351 Details for
Bug 18539
Forbid Koha::Objects->find calls in list context
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18539: remove occurrence in ReNewSubscription.t
Bug-18539-remove-occurrence-in-ReNewSubscriptiont.patch (text/plain), 2.37 KB, created by
Jonathan Druart
on 2017-06-15 18:46:40 UTC
(
hide
)
Description:
Bug 18539: remove occurrence in ReNewSubscription.t
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-06-15 18:46:40 UTC
Size:
2.37 KB
patch
obsolete
>From b870ef8912174a45d8086781e0b384dc246d5d65 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 15 Jun 2017 15:46:17 -0300 >Subject: [PATCH] Bug 18539: remove occurrence in ReNewSubscription.t > >--- > t/db_dependent/00-strict.t | 24 ------------------------ > t/db_dependent/Serials/ReNewSubscription.t | 4 ++-- > 2 files changed, 2 insertions(+), 26 deletions(-) > delete mode 100644 t/db_dependent/00-strict.t > >diff --git a/t/db_dependent/00-strict.t b/t/db_dependent/00-strict.t >deleted file mode 100644 >index 11e9403..0000000 >--- a/t/db_dependent/00-strict.t >+++ /dev/null >@@ -1,24 +0,0 @@ >-# This script is called by the pre-commit git hook to test modules compile >- >-use strict; >-use warnings; >-use Test::More; >-use Test::Strict; >-use File::Spec; >-use File::Find; >-use lib("misc/translator"); >-use lib("installer"); >- >-my @dirs = ( 'acqui', 'admin', 'authorities', 'basket', >- 'catalogue', 'cataloguing', 'changelanguage.pl', 'circ', 'debian', 'docs', >- 'edithelp.pl', 'errors', 'fix-perl-path.PL', 'help.pl', 'installer', >- 'koha_perl_deps.pl', 'kohaversion.pl', 'labels', >- 'mainpage.pl', 'Makefile.PL', 'members', 'misc', 'offline_circ', 'opac', >- 'patroncards', 'reports', 'reserve', 'reviews', >- 'rewrite-config.PL', 'rotating_collections', 'serials', 'services', 'skel', >- 'sms', 'suggestion', 'svc', 'tags', 'tools', 'virtualshelves' ); >- >-$Test::Strict::TEST_STRICT = 0; >-$Test::Strict::TEST_SKIP = [ 'misc/kohalib.pl', 'sms/sms_listen_windows_start.pl', 'misc/plack/koha.psgi' ]; >- >-all_perl_files_ok(@dirs); >diff --git a/t/db_dependent/Serials/ReNewSubscription.t b/t/db_dependent/Serials/ReNewSubscription.t >index 43cc4e8..a214a97 100644 >--- a/t/db_dependent/Serials/ReNewSubscription.t >+++ b/t/db_dependent/Serials/ReNewSubscription.t >@@ -85,9 +85,9 @@ my $subscriptionhistory = $builder->build({ > > # Renew the subscription and check that enddate has not been set > ReNewSubscription($subscription->{subscriptionid},'',"2016-01-01",'','',12,''); >-my @history = Koha::Subscription::Histories->find($subscription->{subscriptionid}); >+my $history = Koha::Subscription::Histories->find($subscription->{subscriptionid}); > >-is ( $history[0]->histenddate(), undef, 'subscription history not empty after renewal'); >+is ( $history->histenddate(), undef, 'subscription history not empty after renewal'); > > # End of tests > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18539
:
63110
|
64338
|
64351
|
65458