Attachment 64386 Details for Bug 18434 – Bug 18434 - Followup - same changes for sort and facet fields

[patch] Bug 18434 - Followup - same changes for sort and facet fields

Bug-18434---Followup---same-changes-for-sort-and-f.patch (text/plain), 1.89 KB, created by Nick Clemens (kidclamp) on 2017-06-16 14:05:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2017-06-16 14:05:46 UTC

Size: 1.89 KB

patch

obsolete

>From b69351d2b28e5ed1a0cd0694d0675fc282ad9c06 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 16 Jun 2017 10:01:12 -0400
>Subject: [PATCH] Bug 18434 - Followup - same changes for sort and facet fields
>
>To test:
>1 - Index some stuff with multiple fields defined for sorting
>  i.e. Authorites - make heading sortable - default is 110a and 111a for
>  heading - a record with 111a empty will make the sort field empty
>2 - view the record:
>curl http://localhost:9200/koha_kohadev_authorities/data/30?pretty=true
>3 - Note the blank field
>4 - Apply patch
>5 - Reindex
>6 - Fields should be correctly populated
>
>Unit tests to follow (once I have the originals working for all)
>---
> Koha/SearchEngine/Elasticsearch.pm | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/SearchEngine/Elasticsearch.pm b/Koha/SearchEngine/Elasticsearch.pm
>index b079dca..43bb0a8 100644
>--- a/Koha/SearchEngine/Elasticsearch.pm
>+++ b/Koha/SearchEngine/Elasticsearch.pm
>@@ -328,7 +328,7 @@ sub get_fixer_rules {
>             $options = '-split => 1' unless $marc_field =~ m|_/| || $type eq 'sum';
>             push @rules, "marc_map('$marc_field','${name}.\$append', $options)";
>             if ($facet) {
>-                push @rules, "marc_map('$marc_field','${name}__facet', $options)";
>+                push @rules, "marc_map('$marc_field','${name}__facet.\$append', $options)";
>             }
>             if ($suggestible) {
>                 push @rules,
>@@ -351,7 +351,7 @@ sub get_fixer_rules {
>             # to do the default thing, which is make it sortable.
>             if ($self->sort_fields()->{$name}) {
>                 if ($sort || !defined $sort) {
>-                    push @rules, "marc_map('$marc_field','${name}__sort', $options)";
>+                    push @rules, "marc_map('$marc_field','${name}__sort.\$append', $options)";
>                 }
>             }
>         }
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18434: 62171 | 62702 | 63451 | 63452 | 63453 | 63473 | 63477 | 63478 | 63479 | 64386 | 64773 | 64786 | 64787 | 64788 | 64789 | 64790