Bugzilla – Attachment 64399 Details for
Bug 18651
Move of checkouts is still not correctly handled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18651: Limit the life span of the LOCK
Bug-18651-Limit-the-life-span-of-the-LOCK.patch (text/plain), 1.75 KB, created by
Jonathan Druart
on 2017-06-16 15:18:21 UTC
(
hide
)
Description:
Bug 18651: Limit the life span of the LOCK
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-06-16 15:18:21 UTC
Size:
1.75 KB
patch
obsolete
>From 630348962ee668966041c694eefcd909b08afed6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 15 Jun 2017 20:25:18 -0300 >Subject: [PATCH] Bug 18651: Limit the life span of the LOCK > >We only need the table to be locked for the fetch, increment, store sequence >--- > C4/Circulation.pm | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 60c29a9..c89624e 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2175,11 +2175,11 @@ sub MarkIssueReturned { > my $do_not_lock = ( exists $ENV{_} && $ENV{_} =~ m|prove| ) || $ENV{KOHA_NO_TABLE_LOCKS}; > $schema->txn_do(sub { > >+ $dbh->do( $query, undef, @bind ); >+ > C4::Context->dbh->do(q|LOCK TABLE old_issues READ|) unless $do_not_lock; > C4::Context->dbh->do(q|LOCK TABLE old_issues WRITE|) unless $do_not_lock; > >- $dbh->do( $query, undef, @bind ); >- > my $original_issue_id = $issue_id; > my $issue = Koha::Checkouts->find( $issue_id ); # FIXME should be fetched earlier > >@@ -2196,6 +2196,8 @@ sub MarkIssueReturned { > $old_checkout_data->{issue_id} = $issue_id; > my $old_checkout = Koha::Old::Checkout->new($old_checkout_data)->store; > >+ C4::Context->dbh->do(q|UNLOCK TABLES|) unless $do_not_lock; >+ > # Update the fines > $dbh->do(q|UPDATE accountlines SET issue_id = ? WHERE issue_id = ?|, undef, $old_checkout->issue_id, $issue->issue_id); > >@@ -2214,8 +2216,6 @@ sub MarkIssueReturned { > my $patron = Koha::Patrons->find( $borrowernumber ); > $item->last_returned_by( $patron ); > } >- >- C4::Context->dbh->do(q|UNLOCK TABLES|) unless $do_not_lock; > }); > > return $issue_id; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18651
:
63629
|
63630
|
63631
|
63632
|
63633
|
63634
|
63635
|
63636
|
63637
|
63654
|
63659
|
63706
|
64352
|
64353
|
64354
|
64355
|
64356
|
64357
|
64394
|
64395
|
64396
|
64397
|
64398
|
64399
|
64448
|
64449
|
64450
|
64451
|
64452
|
64453
|
64454
|
64455
|
64489
|
64490
|
64495
|
65134