Bugzilla – Attachment 64404 Details for
Bug 14698
AtomicUpdater - Keeps track of which updates have been applied to a database
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14698: (follow-up) Koha::AtomicUpdater->find allow hashref as param
Bug-14698-follow-up-KohaAtomicUpdater-find-allow-h.patch (text/plain), 1.48 KB, created by
Lari Taskula
on 2017-06-16 16:14:50 UTC
(
hide
)
Description:
Bug 14698: (follow-up) Koha::AtomicUpdater->find allow hashref as param
Filename:
MIME Type:
Creator:
Lari Taskula
Created:
2017-06-16 16:14:50 UTC
Size:
1.48 KB
patch
obsolete
>From 7817d805331d66da66bb7321fb8fe64e139daf29 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@jns.fi> >Date: Fri, 16 Jun 2017 18:34:12 +0300 >Subject: [PATCH] Bug 14698: (follow-up) Koha::AtomicUpdater->find allow > hashref as param > >Otherwise t/db_dependent/TestBuilder.t fails! > >To test: >1. prove t/db_dependent/Koha/AtomicUpdater.t >2. prove t/db_dependent/TestBuilder.t >--- > Koha/AtomicUpdater.pm | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > >diff --git a/Koha/AtomicUpdater.pm b/Koha/AtomicUpdater.pm >index b33a00c..917c08a 100644 >--- a/Koha/AtomicUpdater.pm >+++ b/Koha/AtomicUpdater.pm >@@ -53,8 +53,7 @@ sub _get_castable_unique_columns { > > @PARAM1 Scalar, issue_id or atomicupdate_id > @RETURNS Koha::AtomicUpdate >-@THROWS Koha::Exception::BadParameter, if @PARAM1 is not a scalar >- Koha::Exception::DuplicateObject, if @PARAM1 matches both the issue_id and atomicupdate_id, >+@THROWS Koha::Exception::DuplicateObject, if @PARAM1 matches both the issue_id and atomicupdate_id, > you should change your issue naming convention. > =cut > >@@ -62,9 +61,7 @@ sub find { > my ( $self, $id ) = @_; > return unless $id; > if (ref($id)) { >- my @cc1 = caller(1); >- my @cc0 = caller(0); >- Koha::Exception::BadParameter->throw(error => $cc1[3]."() -> ".$cc0[3]."():> Given \$id '$id' is not a scalar."); >+ return $self->SUPER::find($id); > } > > my @results = $self->_resultset()->search({'-or' => [ >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14698
:
42112
|
42113
|
42385
|
42386
|
42395
|
42398
|
42426
|
42521
|
42523
|
62141
|
64404
|
102899
|
102900
|
102901
|
102902
|
102903