Attachment 64410 Details for Bug 18692 – Bug 18692 - same with syspref TalkingTechItivaPhone

[patch] Bug 18692 - same with syspref TalkingTechItivaPhone

Bug-18692---same-with-syspref-TalkingTechItivaPhon.patch (text/plain), 2.53 KB, created by Michael Cabus on 2017-06-16 18:24:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Michael Cabus

Created: 2017-06-16 18:24:51 UTC

Size: 2.53 KB

patch

obsolete

>From 2cf36dc917c2bd5533967475e320c75e845beb0d Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Thu, 1 Jun 2017 17:22:42 +0200
>Subject: [PATCH] Bug 18692 - same with syspref TalkingTechItivaPhone
>
>Fixes misplaced columns introduced by previous patch and adds the "-" for phone
>transport type.
>
>To test:
>1. Set SMSSendDriver system preference on
>2. Go to intra and OPAC messaging preferences
>3. By default you should see checkboxes for all messages for SMS
>4. Ensure columns are not misplaced (pushing one column too much to the right)
>5. Delete sms method from one of the messages in message_transports table
>6. Observe that "-" is displayed instead of checkbox for that message for SMS
>7. Repeat same for TalkingTechItivaPhoneNotification system preference.
>   By default it may not have transports in message_transports, so make sure
>   to assign some in order to have the checkboxes visible.
>
>https://bugs.koha-community.org/show_bug.cgi?id=8692
>
>Signed-off-by: Michael Andrew Cabus <michael@bywatersolutons.com>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 4 ++++
> 1 file changed, 4 insertions(+)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>index a653f2d..9a96585 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt
>@@ -77,6 +77,7 @@
>                                             [% END %]
>                                         [% END %]
>                                         [% IF ( TalkingTechItivaPhone ) %]
>+                                            [% IF ( messaging_preference.transport_phone ) %]
>                                             <td>
>                                               [% IF ( messaging_preference.transports_phone ) %]
>                                               <input type="checkbox"
>@@ -90,6 +91,9 @@
>                                                          value="phone" onclick = "document.opacmessaging.none[% messaging_preference.message_attribute_id %].checked=false;" />
>                                               [% END %]
>                                             </td>
>+                                            [% ELSE %]
>+                                                <td>-</td>
>+                                            [% END %]
>                                         [% END %]
> 
>                                         [% IF ( messaging_preference.transport_email ) %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18692: 63814 | 63830 | 63872 | 63897 | 63898 | 63900 | 64409 | 64410 | 65170 | 65171 | 65451 | 65906 | 66731