Attachment 64504 Details for Bug 18214 – Bug 18214: Add check for shared or public list

[patch] Bug 18214: Add check for shared or public list

Bug-18214-Add-check-for-shared-or-public-list.patch (text/plain), 2.05 KB, created by Marcel de Rooy on 2017-06-22 07:08:37 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-06-22 07:08:37 UTC

Size: 2.05 KB

patch

obsolete

>From d638f8d4d89593f7d7b26cd596a281d87cfd5d2d Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Thu, 22 Jun 2017 08:55:16 +0200
>Subject: [PATCH] Bug 18214: Add check for shared or public list
>Content-Type: text/plain; charset=utf-8
>
>Following the idea behind bug 10865, we are only showing the permissions
>when the list is shared or public.
>Adding a simple test in opac-shelves here.
>
>Note 1: Since the owner can always add or delete entries, the permissions
>will not be relevant anymore for a strictly private list.
>
>Note 2: Staff view always shows the permissions. This could have been
>changed here too, but that change is far less urgent (bug 10865 did not
>touch staff view and bug 18228 will rearrange permissions anyway).
>
>Test plan:
>[1] Verify on OPAC that you see the permissions for a private list with
>    shares or a public list. And you do not see them for a private list
>    without shares.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index a7721a6..70a09f5 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -602,7 +602,9 @@
>                                             [% END %]
>                                         </li>
>                                     [% END %]
>-                                    [% INCLUDE list_permissions %]
>+                                    [% IF shelf.category == PUBLIC OR shelf.is_shared %]
>+                                        [% INCLUDE list_permissions %]
>+                                    [% END %]
>                                 </ol>
>                                 [% UNLESS Koha.Preference('OpacAllowPublicListCreation') OR category == PUBLIC %]
>                                     <input type="hidden" name="category" value="[% PRIVATE %]" />
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18214: 60821 | 60822 | 64504