Bugzilla – Attachment 64544 Details for
Bug 12145
Lock for Move up buttons with Marc tag
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12145: [FOLLOW-UP] Separating buttons and tags
Bug-12145-FOLLOW-UP-Separating-buttons-and-tags.patch (text/plain), 3.47 KB, created by
Biblibre Sandboxes
on 2017-06-22 14:01:50 UTC
(
hide
)
Description:
Bug 12145: [FOLLOW-UP] Separating buttons and tags
Filename:
MIME Type:
Creator:
Biblibre Sandboxes
Created:
2017-06-22 14:01:50 UTC
Size:
3.47 KB
patch
obsolete
>From ac2d975a0742796d85d1cc41c0f0aaf2fb4acc6b Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Fri, 2 Jun 2017 04:30:42 +0000 >Subject: [PATCH] Bug 12145: [FOLLOW-UP] Separating buttons and tags >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >This patch fixes the issue in Comment 2. The move-up buttons were inside >the element that gets hidden when 'Show tags' is off, therefore removing >their functionality and making the 'Lock subfield positions' button >useless. This patch separates the buttons and the tags into two separate >span elements, and adds the appropriate CSS. > >To test: >Confirm that 'Lock subfield positions' still works when 'Show tags' >is off. > >Signed-off-by: Eugene Jose Espinoza for KohaCon2017 <eugenegf@yahoo.com> > >Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> >Signed-off-by: Israelex A Veleña for KohaCon17 <israelex19@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/css/addbiblio.css | 7 ++++++- > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt | 6 ++++-- > 2 files changed, 10 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css b/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css >index f49eb61..924449e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css >+++ b/koha-tmpl/intranet-tmpl/prog/css/addbiblio.css >@@ -49,7 +49,7 @@ div.subfield_line label { > clear:left; > } > >-.subfieldcode img { >+.subfieldmoveup img { > cursor: pointer; > } > >@@ -80,6 +80,11 @@ a.tagnum { > text-align:right; > } > >+.subfieldmoveup { >+ display: block; >+ float: left; >+} >+ > .subfieldcode { > display: block; > float: left; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >index 0f6a821..26b5c2f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt >@@ -656,12 +656,14 @@ function Changefwk() { > [% END %] > [% END %] > >- <span class="subfieldcode"> >+ <span class="subfieldmoveup"> > [% IF ( subfield_loo.fixedfield ) %] > <img class="buttonUp" style="display:none;" src="[% interface %]/[% theme %]/img/up.png" onclick="upSubfield('subfield[% subfield_loo.tag %][% subfield_loo.subfield %][% subfield_loo.random %]')" alt="Move Up" title="Move Up" /> > [% ELSE %] > <img class="buttonUp" src="[% interface %]/[% theme %]/img/up.png" onclick="upSubfield('subfield[% subfield_loo.tag %][% subfield_loo.subfield %][% subfield_loo.random %]')" alt="Move Up" title="Move Up" /> > [% END %] >+ </span> >+ <span class="subfieldcode"> > <input type="text" > title="[% subfield_loo.marc_lib %]" > style=" [% IF ( subfield_loo.fixedfield ) %]display:none; [% END %]border:0;" >@@ -671,7 +673,7 @@ function Changefwk() { > maxlength="1" > class="flat" > tabindex="0" /> >- </span> >+ </span> > > [% UNLESS advancedMARCEditor %] > [% IF ( subfield_loo.mandatory ) %]<span class="subfield subfield_mandatory">[% ELSE %]<span class="subfield">[% END %] >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12145
:
62808
|
63906
|
64539
|
64540
|
64543
| 64544