Attachment 64580 Details for Bug 18104 – Bug 18104: Add a test for customized name in AE

[patch] Bug 18104: Add a test for customized name in AE

Bug-18104-Add-a-test-for-customized-name-in-AE.patch (text/plain), 1.79 KB, created by Marcel de Rooy on 2017-06-23 08:15:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-06-23 08:15:29 UTC

Size: 1.79 KB

patch

obsolete

>From fa3bae7329a75271ca16c6f548fb31f14f5becf8 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 23 Jun 2017 10:12:44 +0200
>Subject: [PATCH] Bug 18104: Add a test for customized name in AE
>Content-Type: text/plain; charset=utf-8
>
>Test plan:
>Run t/db_dependent/SIP/Message.t
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/db_dependent/SIP/Message.t | 11 ++++++++++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/SIP/Message.t b/t/db_dependent/SIP/Message.t
>index 088829a..17e8a8c 100755
>--- a/t/db_dependent/SIP/Message.t
>+++ b/t/db_dependent/SIP/Message.t
>@@ -70,7 +70,7 @@ subtest 'Testing Patron Status Request V2' => sub {
> 
> subtest 'Testing Patron Info Request V2' => sub {
>     $schema->storage->txn_begin;
>-    plan tests => 16;
>+    plan tests => 17;
>     $C4::SIP::Sip::protocol_version = 2;
>     test_request_patron_info_v2();
>     $schema->storage->txn_rollback;
>@@ -186,6 +186,15 @@ sub test_request_patron_info_v2 {
>     # No check for custom fields here (unofficial PB, PC and PI)
>     check_field( $respcode, $response, FID_SCREEN_MSG, '.+', 'We have a screen msg', 'regex' );
> 
>+    # Test customized patron name in AE with same sip request
>+    # This implicitly tests C4::SIP::ILS::Patron->name
>+    $server->{account}->{ae_field_template} = "X[% patron.surname %]Y";
>+    $msg = C4::SIP::Sip::MsgType->new( $siprequest, 0 );
>+    undef $response;
>+    $msg->handle_patron_info( $server );
>+    $respcode = substr( $response, 0, 2 );
>+    check_field( $respcode, $response, FID_PERSONAL_NAME, 'X' . $patron2->{surname} . 'Y', 'Check customized patron name' );
>+
>     # Check empty password and verify CQ again
>     $siprequest = PATRON_INFO. 'engYYYYMMDDZZZZHHMMSS'.'Y         '.
>         FID_INST_ID. $branchcode. '|'.
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18104: 60845 | 60876 | 64579 | 64580 | 64581