Attachment 64698 Details for Bug 18184 – Bug 18184: Show frequency and numbering pattern info when viewing all subs attached to a biblio

[patch] Bug 18184: Show frequency and numbering pattern info when viewing all subs attached to a biblio

Bug-18184-Show-frequency-and-numbering-pattern-inf.patch (text/plain), 1.81 KB, created by Biblibre Sandboxes on 2017-06-28 09:54:31 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Biblibre Sandboxes

Created: 2017-06-28 09:54:31 UTC

Size: 1.81 KB

patch

obsolete

>From 1506476f097e7b617101660c6ceaccab559c7442 Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Tue, 4 Apr 2017 23:51:16 +0000
>Subject: [PATCH] Bug 18184: Show frequency and numbering pattern info when
> viewing all subs attached to a biblio
>
>To test:
>1) Go to Serials, find a serial with more than one subscription
>2) Click Serial collection
>3) Notice how Frequency and Numbering pattern are filled out correctly
>4) Click 'see any sub attached to this biblio'
>5) Notice how Frequency and Numbering pattern are now missing info
>6) Apply patch and refresh page
>7) Confirm Frequency and Numbering pattern now show as expected
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: sonia BOUIS <sonia.bouis@univ-lyon3.fr>
>---
> serials/serials-collection.pl | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/serials/serials-collection.pl b/serials/serials-collection.pl
>index 5182cbd..e9cb3fd 100755
>--- a/serials/serials-collection.pl
>+++ b/serials/serials-collection.pl
>@@ -134,7 +134,13 @@ if (@subscriptionid){
>   $subscriptions=PrepareSerialsData(\@subscriptioninformation);
>   $subscriptioncount = CountSubscriptionFromBiblionumber($subscriptiondescs->[0]{'biblionumber'});
> } else {
>-  $subscriptiondescs = GetSubscriptionsFromBiblionumber($biblionumber) ;
>+  $subscriptiondescs = GetSubscriptionsFromBiblionumber($biblionumber);
>+  foreach my $s (@$subscriptiondescs) {
>+    my $frequency = C4::Serials::Frequency::GetSubscriptionFrequency($s->{periodicity});
>+    my $numberpattern = C4::Serials::Numberpattern::GetSubscriptionNumberpattern($s->{numberpattern});
>+    $s->{frequency} = $frequency;
>+    $s->{numberpattern} = $numberpattern;
>+  }
>   my $subscriptioninformation = GetFullSubscriptionsFromBiblionumber($biblionumber);
>   $subscriptions=PrepareSerialsData($subscriptioninformation);
> }
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 18184: 61859 | 64698 | 68456