Bugzilla – Attachment 64738 Details for
Bug 18781
Translatability: Get rid of exposed tt directives in openlibrary-readapi.inc
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 18781: Translatability: Get rid of exposed tt directives in openlibrary-readapi.inc
SIGNED-OFF-Bug-18781-Translatability-Get-rid-of-ex.patch (text/plain), 1.76 KB, created by
Mark Tompsett
on 2017-06-30 01:52:45 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 18781: Translatability: Get rid of exposed tt directives in openlibrary-readapi.inc
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-06-30 01:52:45 UTC
Size:
1.76 KB
patch
obsolete
>From ef9e7f1e804349429ffae6f6d862055c8040a058 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Mon, 12 Jun 2017 09:07:28 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 18781: Translatability: Get rid of exposed > tt directives in openlibrary-readapi.inc > >The file koha-tmpl/opac-tmpl/bootstrap/en/includes/openlibrary-readapi.inc >exposes template directives to translation. The only string that should >appear in .po from this file is "Open Library: " > >To test: >- Apply patch >- Verify that code changes make sense >- Bonus test: create a new language 'aa-AA', verify in aa-AA-opac-bootstrap.po > that there is only the following string for openlibrary-readapi.inc: >msgid "Open Library: " >msgstr "" > >NOTE: Followed a test plan similar to bug 18776 comment 3 > >Signed-off-by: Mark Tompsett <mtompset@hotmail.com> >--- > .../opac-tmpl/bootstrap/en/includes/openlibrary-readapi.inc | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/openlibrary-readapi.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/openlibrary-readapi.inc >index 5681000d81..91cf4d7704 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/openlibrary-readapi.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/openlibrary-readapi.inc >@@ -1,10 +1,4 @@ >-[%# Input params: >- bib - search result biblio record >-%] >-[% IF OpenLibrarySearch && ( >- bib.normalized_isbn || >- bib.lccn || >- bib.normalized_oclc >-) %] >+[%# Input params: bib - search result biblio record %] >+[% IF OpenLibrarySearch && ( bib.normalized_isbn || bib.lccn || bib.normalized_oclc ) %] > <div class="ol_readapi_book" isbn="[% bib.normalized_isbn %]" lccn="[% bib.lccn %]" oclc="[% bib.normalized_oclc %]">Open Library: </div> > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18781
:
64192
|
64738
|
66643