Attachment 64879 Details for Bug 18276 – Bug 18276: Remove GetBiblioFromItemNumber - ILSDI

[patch] Bug 18276: Remove GetBiblioFromItemNumber - ILSDI

Bug-18276-Remove-GetBiblioFromItemNumber---ILSDI.patch (text/plain), 1.85 KB, created by Marcel de Rooy on 2017-07-07 07:29:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-07-07 07:29:39 UTC

Size: 1.85 KB

patch

obsolete

>From f2f7a4647964a07cfef07d35ef9f91459085cf0a Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 15 Mar 2017 10:41:29 -0300
>Subject: [PATCH] Bug 18276: Remove GetBiblioFromItemNumber - ILSDI
>Content-Type: text/plain; charset=utf-8
>
>Test plan:
>Hit /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=51&show_holds=1
>The results should be the same before and after this patch
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/ILSDI/Services.pm | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
>diff --git a/C4/ILSDI/Services.pm b/C4/ILSDI/Services.pm
>index c1632d5..a514f50 100644
>--- a/C4/ILSDI/Services.pm
>+++ b/C4/ILSDI/Services.pm
>@@ -421,15 +421,20 @@ sub GetPatronInfo {
> 
>             my $unblessed_hold = $hold->unblessed;
>             # Get additional informations
>-            my $item = GetBiblioFromItemNumber( $hold->itemnumber, undef );
>+            my $item = Koha::Items->find( $hold->itemnumber );
>+            my $biblio = $item->biblio;
>+            my $biblioitem = $biblio->biblioitem;
>             my $library = Koha::Libraries->find( $hold->branchcode ); # Should $hold->get_library
>             my $branchname = $library ? $library->branchname : '';
> 
>             # Remove unwanted fields
>+            $item = $item->unblessed;
>             delete $item->{'more_subfields_xml'};
>+            $biblio = $biblio->unblessed;
>+            $biblioitem = $biblioitem->unblessed;
> 
>             # Add additional fields
>-            $unblessed_hold->{item}       = $item;
>+            $unblessed_hold->{item}       = { %$item, %$biblio, %$biblioitem };
>             $unblessed_hold->{branchname} = $branchname;
>             $unblessed_hold->{title}      = GetBiblio( $hold->biblionumber )->{'title'}; # Should be $hold->get_biblio
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18276: 61122 | 61123 | 61124 | 61125 | 61126 | 61177 | 61178 | 61179 | 61180 | 61181 | 62081 | 62082 | 62083 | 62084 | 62085 | 62476 | 62477 | 62478 | 62479 | 62480 | 62481 | 63121 | 63122 | 63123 | 63124 | 63125 | 63126 | 63166 | 63294 | 63295 | 63296 | 63297 | 63298 | 63299 | 63300 | 64748 | 64809 | 64810 | 64811 | 64812 | 64813 | 64814 | 64815 | 64816 | 64817 | 64878 | 64879 | 64880 | 64881 | 64882 | 64883 | 64884 | 64885 | 64886 | 64887 | 64974 | 64975