Bugzilla – Attachment 64887 Details for
Bug 18276
Koha::Biblio - Remove GetBiblioFromItemNumber
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18276: [QA Follow-up] Fix two new calls
Bug-18276-QA-Follow-up-Fix-two-new-calls.patch (text/plain), 2.57 KB, created by
Marcel de Rooy
on 2017-07-07 07:30:18 UTC
(
hide
)
Description:
Bug 18276: [QA Follow-up] Fix two new calls
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-07-07 07:30:18 UTC
Size:
2.57 KB
patch
obsolete
>From b51288469c069ca304bc94c00a75b233798d4150 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 7 Jul 2017 09:04:21 +0200 >Subject: [PATCH] Bug 18276: [QA Follow-up] Fix two new calls >Content-Type: text/plain; charset=utf-8 > >Found two calls in opac-issue-note.pl and svc/patron_notes. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > opac/opac-issue-note.pl | 8 ++++---- > opac/svc/patron_notes | 4 ++-- > 2 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/opac/opac-issue-note.pl b/opac/opac-issue-note.pl >index becd708..832e365 100755 >--- a/opac/opac-issue-note.pl >+++ b/opac/opac-issue-note.pl >@@ -53,11 +53,11 @@ $template->param( > my $issue_id = $query->param('issue_id'); > my $issue = Koha::Checkouts->find( $issue_id ); > my $itemnumber = $issue->itemnumber; >-my $biblio = GetBiblioFromItemNumber($itemnumber); >+my $biblio = $issue->item->biblio; > $template->param( > issue_id => $issue_id, >- title => $biblio->{'title'}, >- author => $biblio->{'author'}, >+ title => $biblio->title, >+ author => $biblio->author, > note => $issue->note, > itemnumber => $issue->itemnumber, > ); >@@ -75,7 +75,7 @@ if ( $action eq 'issuenote' && C4::Context->preference('AllowCheckoutNotes') ) { > letter_code => 'PATRON_NOTE', > branchcode => $branch, > tables => { >- 'biblio' => $biblio->{biblionumber}, >+ 'biblio' => $biblio->biblionumber, > 'borrowers' => $member->{borrowernumber}, > }, > ); >diff --git a/opac/svc/patron_notes b/opac/svc/patron_notes >index d241f0c..d68bb69 100755 >--- a/opac/svc/patron_notes >+++ b/opac/svc/patron_notes >@@ -79,13 +79,13 @@ if ($is_ajax) { > $issue->set({ notedate => dt_from_string(), note => $clean_note })->store; > if($clean_note) { # only send email if note not empty > my $branch = Koha::Libraries->find( $issue->branchcode ); >- my $biblio = GetBiblioFromItemNumber($issue->itemnumber); >+ my $biblionumber = $issue->item->biblionumber; > my $letter = C4::Letters::GetPreparedLetter ( > module => 'circulation', > letter_code => 'PATRON_NOTE', > branchcode => $branch, > tables => { >- 'biblio' => $biblio->{biblionumber}, >+ 'biblio' => $biblionumber, > 'borrowers' => $member->{borrowernumber}, > }, > ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18276
:
61122
|
61123
|
61124
|
61125
|
61126
|
61177
|
61178
|
61179
|
61180
|
61181
|
62081
|
62082
|
62083
|
62084
|
62085
|
62476
|
62477
|
62478
|
62479
|
62480
|
62481
|
63121
|
63122
|
63123
|
63124
|
63125
|
63126
|
63166
|
63294
|
63295
|
63296
|
63297
|
63298
|
63299
|
63300
|
64748
|
64809
|
64810
|
64811
|
64812
|
64813
|
64814
|
64815
|
64816
|
64817
|
64878
|
64879
|
64880
|
64881
|
64882
|
64883
|
64884
|
64885
|
64886
| 64887 |
64974
|
64975