Bugzilla – Attachment 64914 Details for
Bug 18613
Deleting a Letter from a library as superlibrarian deletes the "All libraries" rule
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18613: Remove letter rule correctly as superlibrarian
Bug-18613-Remove-letter-rule-correctly-as-superlib.patch (text/plain), 1.45 KB, created by
Julian Maurice
on 2017-07-07 13:46:15 UTC
(
hide
)
Description:
Bug 18613: Remove letter rule correctly as superlibrarian
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2017-07-07 13:46:15 UTC
Size:
1.45 KB
patch
obsolete
>From c08b69e7620f43db25a6c0de281aa5174b30f5f7 Mon Sep 17 00:00:00 2001 >From: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> >Date: Fri, 19 May 2017 09:23:17 +0000 >Subject: [PATCH] Bug 18613: Remove letter rule correctly as superlibrarian > >TEST PLAN > >(reproducing bug) >1 - Set 'IndependantBranches' to enable >2 - Log in as Superlibrarian. >3 - Create 3 rules > - 1 for all librairies (1) > - 1 for the library of the superlibrarian (2) > - 1 for another library (3) >4 - Try to delete them and see them and see that (3) isn't the good one > >(checking patch) >5 - Apply patch >6 - Try again 3- >7 - Connect as not superlibrarian >8 - Try again 3- > >Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > C4/Letters.pm | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > >diff --git a/C4/Letters.pm b/C4/Letters.pm >index ada27943b0..3935ffcdbf 100644 >--- a/C4/Letters.pm >+++ b/C4/Letters.pm >@@ -203,11 +203,9 @@ sub getletter { > $lang = 'default' unless( $lang && C4::Context->preference('TranslateNotices') ); > > >- if ( C4::Context->preference('IndependentBranches') >- and $branchcode >- and C4::Context->userenv ) { >- >- $branchcode = C4::Context->userenv->{'branch'}; >+ my $only_my_library = C4::Context->only_my_library; >+ if ( $only_my_library and $branchcode ) { >+ $branchcode = C4::Context::mybranch(); > } > $branchcode //= ''; > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18613
:
63484
|
63485
|
63486
|
63578
|
64616
|
64912
| 64914 |
64987