Bugzilla – Attachment 64936 Details for
Bug 18869
Patron clubs and templates tables look strange when empty
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18869: [FOLLOW-UP] Make page reload after club or template delete
Bug-18869-FOLLOW-UP-Make-page-reload-after-club-or.patch (text/plain), 4.47 KB, created by
Aleisha Amohia
on 2017-07-09 22:00:42 UTC
(
hide
)
Description:
Bug 18869: [FOLLOW-UP] Make page reload after club or template delete
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2017-07-09 22:00:42 UTC
Size:
4.47 KB
patch
obsolete
>From ccce5e7b604e63dfe63471e8fbe30d1188599358 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Sun, 9 Jul 2017 21:57:06 +0000 >Subject: [PATCH] Bug 18869: [FOLLOW-UP] Make page reload after club or > template delete > >If deleting the last club or template in a table, the row is deleted >from the webpage by ajax so the nice blue bubble message does not show. >This patch forces the page to reload so the blue bubble message shows >instead of the empty table. > >To test: >Confirm that the blue message shows when tables are empty. Add a >template and a club, then delete a club. Confirm the page reloads and >the message shows. Test with template > >Sponsored-by: Catalyst IT >--- > .../intranet-tmpl/prog/en/modules/clubs/clubs.tt | 23 +++++++++++----------- > 1 file changed, 11 insertions(+), 12 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt >index a65cd0c..2185156 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/clubs/clubs.tt >@@ -36,7 +36,7 @@ > data: { id: id }, > success: function( data ) { > if ( data.success ) { >- tTable.fnDeleteRow(a.closest("tr")[0]); >+ location.reload(); > } else { > alert(_("Unable to delete template!")); > } >@@ -54,7 +54,7 @@ > data: { id: id }, > success: function( data ) { > if ( data.success ) { >- cTable.fnDeleteRow(a.closest("tr")[0]); >+ location.reload(); > } else { > alert(_("Unable to delete club!")); > } >@@ -232,22 +232,21 @@ > Actions <b class="caret"></b> > </a> > <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="clubactions[% c.id %]"> >- <li> >- [% IF ( c.club_enrollments.count ) %] >- <a class="btn btn-xs btn-default" href="club-enrollments.pl?id=[% c.id %]"> >- [% ELSE %] >- <a class="btn btn-xs btn-default disabled" href="club-enrollments.pl?id=[% c.id %]"> >- [% END %] >- <i class="fa fa-list-ul"></i> Enrollments >- </li> >+ [% IF ( c.club_enrollments.count ) %] >+ <li> >+ <a href="club-enrollments.pl?id=[% c.id %]"> >+ <i class="fa fa-list-ul"></i> Enrollments >+ </a> >+ </li> >+ [% END %] > [% IF CAN_user_clubs_edit_clubs %] > <li> >- <a class="btn btn-xs btn-default" href="clubs-add-modify.pl?id=[% c.id %]"> >+ <a href="clubs-add-modify.pl?id=[% c.id %]"> > <i class="fa fa-pencil"></i> Edit > </a> > </li> > <li> >- <a class="btn btn-xs btn-default" href="#" onclick='ConfirmDeleteClub([% c.id %], "[% c.name | html %]", $(this) ); return false;'> >+ <a href="#" onclick='ConfirmDeleteClub([% c.id %], "[% c.name | html %]", $(this) ); return false;'> > <i class="fa fa-trash"></i> Delete > </a> > </li> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18869
:
64684
|
64687
|
64936
|
64946
|
65443
|
65444
|
65445
|
66650
|
66651
|
66652