Bugzilla – Attachment 64961 Details for
Bug 18923
Resolve a warn in Biblio::GetCOinSBiblio
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18923: Warning in Biblio::GetCOinSBiblio
Bug-18923-Warning-in-BiblioGetCOinSBiblio.patch (text/plain), 1.50 KB, created by
Marcel de Rooy
on 2017-07-10 13:03:33 UTC
(
hide
)
Description:
Bug 18923: Warning in Biblio::GetCOinSBiblio
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-07-10 13:03:33 UTC
Size:
1.50 KB
patch
obsolete
>From 091f8450c89c94cd60a3af6f3a06df62bd151ac2 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Mon, 10 Jul 2017 14:54:56 +0200 >Subject: [PATCH] Bug 18923: Warning in Biblio::GetCOinSBiblio >Content-Type: text/plain; charset=utf-8 > >Use of uninitialized value in concatenation (.) or string at C4/Biblio.pm line 1456. > >Test plan: >Enable COinSinOPACResults. >Without this patch, do some opac searches. Check the log. >Apply this patch, search again and check the log. >--- > C4/Biblio.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 80ca362..1792cb6 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -1426,9 +1426,9 @@ sub GetCOinSBiblio { > $isbn = $record->subfield( '773', 'z' ) || ''; > $issn = $record->subfield( '773', 'x' ) || ''; > if ($mtx eq 'journal') { >- $title .= "&rft.title=" . (($record->subfield( '773', 't' ) || $record->subfield( '773', 'a'))); >+ $title .= "&rft.title=" . ( $record->subfield( '773', 't' ) || $record->subfield( '773', 'a') || q{} ); > } else { >- $title .= "&rft.btitle=" . (($record->subfield( '773', 't' ) || $record->subfield( '773', 'a')) || ''); >+ $title .= "&rft.btitle=" . ( $record->subfield( '773', 't' ) || $record->subfield( '773', 'a') || q{} ); > } > foreach my $rel ($record->subfield( '773', 'g' )) { > if ($pages) { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18923
:
64961
|
67835
|
67999
|
68070