Bugzilla – Attachment 64995 Details for
Bug 18672
Creation Date and Modification Date are the same for a list in the Lists Module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18672: Test for fixing overwriting creation date
Bug-18672-Test-for-fixing-overwriting-creation-dat.patch (text/plain), 1.94 KB, created by
Marcel de Rooy
on 2017-07-11 11:55:29 UTC
(
hide
)
Description:
Bug 18672: Test for fixing overwriting creation date
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2017-07-11 11:55:29 UTC
Size:
1.94 KB
patch
obsolete
>From 92f2596fa2e2702b04ff52d25edba8d4ef6341ea Mon Sep 17 00:00:00 2001 >From: =?utf-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Mon, 29 May 2017 10:17:06 +0200 >Subject: [PATCH] Bug 18672: Test for fixing overwriting creation date >Content-Type: text/plain; charset=utf-8 > >Use this test to highlight issue: >prove -v t/db_dependent/Virtualshelves.t > >After applying patch for Koha/Virtualshelf.pm it should turn green > >Signed-off-by: Lee Jamison <ldjamison@marywood.edu> >Works correctly according to test case. Passes QA Tools and the >indicated t/db_dependent/Virtualshelves.t unit test. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > t/db_dependent/Virtualshelves.t | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Virtualshelves.t b/t/db_dependent/Virtualshelves.t >index 2bbf00e..4e7e314 100644 >--- a/t/db_dependent/Virtualshelves.t >+++ b/t/db_dependent/Virtualshelves.t >@@ -19,7 +19,7 @@ $dbh->{AutoCommit} = 0; > teardown(); > > subtest 'CRUD' => sub { >- plan tests => 12; >+ plan tests => 13; > my $patron = $builder->build({ > source => 'Borrower', > }); >@@ -43,6 +43,13 @@ subtest 'CRUD' => sub { > is( $shelf->allow_change_from_others, 0, 'The default value for allow_change_from_others should be 0' ); > is( output_pref($shelf->created_on), output_pref(dt_from_string), 'The creation time should have been set to today' ); > >+ my $shelf_18672 = Koha::Virtualshelves->find( $shelf->shelfnumber ); # Bug 18672 >+ my $created_18672 = $shelf_18672->created_on; >+ sleep 2; # Wait 2 seconds, then store >+ $shelf->store; >+ $shelf_18672 = Koha::Virtualshelves->find( $shelf->shelfnumber ); >+ is($shelf_18672->created_on, $created_18672, 'Creation date is the same after update (Bug 18672)' ); >+ > my $retrieved_shelf = Koha::Virtualshelves->find( $shelf->shelfnumber ); > > is( $retrieved_shelf->shelfname, $shelf->shelfname, 'Find should correctly return the shelfname' ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18672
:
63720
|
63781
|
63782
|
64063
|
64585
|
64586
|
64587
|
64994
| 64995 |
64996