Bugzilla – Attachment 65027 Details for
Bug 18918
Exporting bibs in CSV when you have no CSV profiles created causes error
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18918: Disable CSV option if no CSV profiles exist
Bug-18918-Disable-CSV-option-if-no-CSV-profiles-ex.patch (text/plain), 2.00 KB, created by
Jonathan Druart
on 2017-07-13 19:43:11 UTC
(
hide
)
Description:
Bug 18918: Disable CSV option if no CSV profiles exist
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2017-07-13 19:43:11 UTC
Size:
2.00 KB
patch
obsolete
>From 7723ffdd130996ec946d5b9149f90cb0cdc447fc Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Mon, 10 Jul 2017 02:31:22 +0000 >Subject: [PATCH] Bug 18918: Disable CSV option if no CSV profiles exist > >To test: >1) Confirm you have no MARC CSV profiles (tools -> csv profiles) >2) Go to Tools -> Export data >3) Select the CSV file format for biblios >4) Notice the CSV profile dropdown shows up but the dropdown is empty >5) Click the Export button, notice Koha breaks >6) Go back and apply the patch, refresh >7) Notice the CSV option is now disabled in the file format menu >8) If you hover over CSV, an appropriate message should show explaining >why it is disabled >9) Create a CSV profile for MARC >10) Go back to Export and you should be able to use CSV now without >problem > >Sponsored-by: Catalyst IT > >Signed-off-by: Lee Jamison <ldjamison@marywood.edu> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt >index eb0069eca1..fc9892ec5e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/export.tt >@@ -164,7 +164,11 @@ $(document).ready(function() { > <select id="output_format" name="output_format"> > <option value="iso2709">marc</option> > <option value="xml">xml</option> >- <option value="csv">csv</option> >+ [% IF csv_profiles %] >+ <option value="csv">csv</option> >+ [% ELSE %] >+ <option value="csv" disabled data-toggle="tooltip" data-placement="left" title="You must create a CSV profile for MARC exports to use this option.">csv</option> >+ [% END %] > </select> > </li> > <li class="csv_profiles"> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18918
:
64945
|
64964
| 65027