Attachment 65126 Details for Bug 18941 – Bug 18941 - C4::Budgets GetBudgetByCode should return active budgets over inactive budgets

[patch] Bug 18941 - C4::Budgets GetBudgetByCode should return active budgets over inactive budgets

Bug-18941---C4Budgets-GetBudgetByCode-should-retur.patch (text/plain), 1.28 KB, created by Nick Clemens (kidclamp) on 2017-07-19 18:54:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2017-07-19 18:54:59 UTC

Size: 1.28 KB

patch

obsolete

>From 7d198f9d9bfcc9c98b4b301c981849648b2411a9 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Fri, 14 Jul 2017 11:25:42 +0000
>Subject: [PATCH] Bug 18941 - C4::Budgets GetBudgetByCode should return active
> budgets over inactive budgets
>
>To test:
>1 - Create an active budget
>2 - Create an inactive budget
>3 - Ensure they each have a fund with the same code
>4 - Set MarcFieldsToOrder to get the budget_code from a marc field
>5 - Stage a file using the duplicated code
>6 - Add to a basket from the staged file
>7 - Add the items
>8 - Note funds are encumbered from the inactive budget
>9 - Apply patch
>10 - Repeat 5-8 with a new basket
>11 - Note the active budget is now used
>---
> C4/Budgets.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Budgets.pm b/C4/Budgets.pm
>index bcc84db..1c0c201 100644
>--- a/C4/Budgets.pm
>+++ b/C4/Budgets.pm
>@@ -777,10 +777,11 @@ sub GetBudgetByCode {
> 
>     my $dbh = C4::Context->dbh;
>     my $query = qq{
>-        SELECT *
>+        SELECT aqbudgets.*
>         FROM aqbudgets
>+        JOIN aqbudgetperiods USING (budget_period_id)
>         WHERE budget_code = ?
>-        ORDER BY budget_id DESC
>+        ORDER BY budget_period_active DESC, budget_id DESC
>         LIMIT 1
>     };
>     my $sth = $dbh->prepare( $query );
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 18941: 65049 | 65050 | 65125 | 65126 | 65441 | 65442 | 65847 | 65848