Bugzilla – Attachment 65161 Details for
Bug 18965
branch transfer limits pagination save bug
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18965 - branch transfer limits pagination save bug
Bug-18965---branch-transfer-limits-pagination-save.patch (text/plain), 1.63 KB, created by
Fridolin Somers
on 2017-07-21 09:18:54 UTC
(
hide
)
Description:
Bug 18965 - branch transfer limits pagination save bug
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2017-07-21 09:18:54 UTC
Size:
1.63 KB
patch
obsolete
>From 9161b348457d2fe882d46b8cde5cc1d0d3b94f29 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Thu, 20 Jul 2017 16:08:59 +0200 >Subject: [PATCH] Bug 18965 - branch transfer limits pagination save bug > >In branch transfer limits, tables are paginated with 20 rows by default. > >The bug is that datatable not only hides rows, they are not in form. >So when submitting form, rows not visible are erased. > >Test plan : >Wihout patch : >- Create 22 branches, you can hack the creation form by manualling calling URL : /cgi-bin/koha/admin/branches.pl?op=add_validate&branchcode=Bxx&branchname=Bxx >- Go to Administration > Library transfer limits >- You see table first page : only 20 first rows are shown >- You see all checkboxes are checked >- Go to second page of this table >- Save >=> You see table first page with all checkboxes unchecked >With patch the is no pagination, all checkboxes are shown when you save >--- > koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt >index 2ff8f84..d8a029d 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branch_transfer_limits.tt >@@ -36,7 +36,7 @@ > "aoColumnDefs": [ > { "aTargets": [ -1 ], "bSortable": false, "bSearchable": false }, > ], >- "sPaginationType": "four_button" >+ 'bPaginate': false > })); > }); > //]]> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18965
:
65161
|
65175
|
65180