Bugzilla – Attachment 65165 Details for
Bug 18955
Autocomplete is on in OPAC password recovery
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18955 - autocomplete is on in OPAC password recovery
Bug-18955---autocomplete-is-on-in-OPAC-password-re.patch (text/plain), 2.57 KB, created by
Nick Clemens (kidclamp)
on 2017-07-21 10:24:25 UTC
(
hide
)
Description:
Bug 18955 - autocomplete is on in OPAC password recovery
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-07-21 10:24:25 UTC
Size:
2.57 KB
patch
obsolete
>From f2e0196e1cdf791bb2d37978e74e161f248cf49d Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 19 Jul 2017 09:48:04 +0200 >Subject: [PATCH] Bug 18955 - autocomplete is on in OPAC password recovery >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >In OPAC password recovery form autocomplete is not disabled. >So when login or email is entered, it is saved in browser input history for autocomplete. >This is a major issue for OPAC on computers with public access. > >This patch adds autocomplete off on forms. > >Test : >- Enable system preferences OpacPasswordChange and OpacResetPassword >- Go to OPAC >- Be sure to not be logged in >- Click on "Forgot your password?" >- Enter a loggin and email and Submit >=> Without patch there is an autocompletion with values you entered >=> With patch there is no autocompletion > >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt >index 6c445b1..4f3f857 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-password-recovery.tt >@@ -78,7 +78,7 @@ > [% IF (!Koha.Preference('OpacResetPassword')) %] > <div class="alert alert-info">You can't reset your password.</div> > [% ELSIF (password_recovery) %] >- <form action="/cgi-bin/koha/opac-password-recovery.pl" method="post"> >+ <form action="/cgi-bin/koha/opac-password-recovery.pl" method="post" autocomplete="off"> > <input type="hidden" name="koha_login_context" value="opac" /> > <fieldset> > <p>To reset your password, enter your login and your email address. >@@ -92,7 +92,7 @@ > </fieldset> > </form> > [% ELSIF (new_password) %] >- <form action="/cgi-bin/koha/opac-password-recovery.pl" method="post"> >+ <form action="/cgi-bin/koha/opac-password-recovery.pl" method="post" autocomplete="off"> > <input type="hidden" name="koha_login_context" value="opac" /> > <fieldset> > <div class="alert alert-info">The password must contain at least [% minPassLength %] characters.</div> >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18955
:
65092
|
65138
| 65165