Attachment 65260 Details for Bug 18931 – Bug 18931: (followup) Tidy text

[patch] Bug 18931: (followup) Tidy text

Bug-18931-followup-Tidy-text.patch (text/plain), 4.29 KB, created by Tomás Cohen Arazi (tcohen) on 2017-07-25 18:00:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2017-07-25 18:00:18 UTC

Size: 4.29 KB

patch

obsolete

>From 556ac68c08b668e796c186d100f0749ae949ba93 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 25 Jul 2017 14:37:55 -0300
>Subject: [PATCH] Bug 18931: (followup) Tidy text
>
>Some minor style and idiomatic issues.
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 36 +++++++++++++-----------
> 1 file changed, 19 insertions(+), 17 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>index 134a53f..9a4e917 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
>@@ -140,37 +140,39 @@
>         [% IF has_ai_issues %]
>             <h2>Data problems</h2>
>             <p>
>-            The following tables have problems with their auto_increment values which may lead to data lost. You should not ignore this warning.
>-            The problem is that innodb does not keep auto_increment across SQL server restarts (it is only set in memory).
>+            Some of your tables have problems with their auto_increment values which may lead to data loss. <strong>You should not ignore this warning</strong>.
>+            The problem is that InnoDB does not keep auto_increment across SQL server restarts (it is only set in memory).
>             So on server startup the auto_increment values are set to max(table.id)+1.
>             </p>
>             <p>
>             See the <a href="https://wiki.koha-community.org/wiki/DBMS_auto_increment_fix">related wiki page</a> to know how to avoid this problem.
>             </p>
>+
>+            <h3>Problems found</h3>
>             [% IF ai_patrons %]
>-                <h3>Patrons</h3>
>-                The following ids exist in both the borrowers and deletedborrowers table:
>-                [% FOR p IN ai_patrons %][% p.borrowernumber %][% UNLESS loop.last %], [% END %][% END %]
>+                <h4>Patrons</h4>
>+                <p>The following ids exist in both <strong>borrowers</strong> and <strong>deletedborrowers</strong> tables:
>+                [% FOR p IN ai_patrons %][% p.borrowernumber %][% UNLESS loop.last %], [% END %][% END %]</p>
>             [% END %]
>             [% IF ai_biblios %]
>-                <h3>Biblios</h3>
>-                The following ids exist in both the biblio and deletedbiblio table:
>-                [% FOR b IN ai_biblios %][% b.biblionumber %][% UNLESS loop.last %], [% END %][% END %]
>+                <h4>Biblios</h4>
>+                <p>The following ids exist in both <strong>biblio</strong> and <strong>deletedbiblio</strong> tables:
>+                [% FOR b IN ai_biblios %][% b.biblionumber %][% UNLESS loop.last %], [% END %][% END %]</p>
>             [% END %]
>             [% IF ai_items %]
>-                <h3>Items</h3>
>-                The following ids exist in both the items and deleteditems table:
>-                [% FOR i IN ai_items %][% i.itemnumber %][% UNLESS loop.last %], [% END %][% END %]
>+                <h4>Items</h4>
>+                <p>The following ids exist in both <strong>items</strong> and <strong>deleteditems</strong> tables:
>+                [% FOR i IN ai_items %][% i.itemnumber %][% UNLESS loop.last %], [% END %][% END %]</p
>             [% END %]
>             [% IF ai_checkouts %]
>-                <h3>Checkouts</h3>
>-                The following ids exist in both the issues and old_issues table:
>-                [% FOR c IN ai_checkouts %][% c.issue_id %][% UNLESS loop.last %], [% END %][% END %]
>+                <h4>Checkouts</h4>
>+                <p>The following ids exist in both <strong>issues</strong> and <strong>old_issues</strong> tables:
>+                [% FOR c IN ai_checkouts %][% c.issue_id %][% UNLESS loop.last %], [% END %][% END %]</p>
>             [% END %]
>             [% IF ai_holds %]
>-                <h3>Holds</h3>
>-                The following ids exist in both the holds and old_reserves table:
>-                [% FOR h IN ai_holds %][% h.issue_id %][% UNLESS loop.last %], [% END %][% END %]
>+                <h4>Holds</h4>
>+                <p>The following ids exist in both <strong>holds</strong> and <strong>old_reserves</strong> table:
>+                [% FOR h IN ai_holds %][% h.issue_id %][% UNLESS loop.last %], [% END %][% END %]</p>
>             [% END %]
>         [% END %]
> 
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 18931: 65010 | 65157 | 65188 | 65189 | 65209 | 65210 | 65211 | 65212 | 65255 | 65256 | 65257 | 65258 | 65259 | 65260 | 65266 | 65267 | 65299