Bugzilla – Attachment 65293 Details for
Bug 18966
Move of checkouts - Deal with duplicate IDs at DBMS level
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[16.05.x] Bug 18966: fix unneeded INSERT in AddReturn()
1605x-Bug-18966-fix-unneeded-INSERT-in-AddReturn.patch (text/plain), 1007 bytes, created by
Mason James
on 2017-07-27 13:34:26 UTC
(
hide
)
Description:
[16.05.x] Bug 18966: fix unneeded INSERT in AddReturn()
Filename:
MIME Type:
Creator:
Mason James
Created:
2017-07-27 13:34:26 UTC
Size:
1007 bytes
patch
obsolete
>From 7bc279285b587787c07e2a62d79e4bf27deb3e23 Mon Sep 17 00:00:00 2001 >From: Mason James <mtj@kohaaloha.com> >Date: Fri, 28 Jul 2017 01:28:00 +1200 >Subject: [PATCH] [16.05.x] Bug 18966: fix unneeded INSERT in AddReturn() >Content-Type: text/plain; charset="utf-8" > >--- > C4/Circulation.pm | 2 -- > 1 file changed, 2 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 11eced2..76c557a 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -2156,8 +2156,6 @@ sub MarkIssueReturned { > # Create the old_issues entry > my $old_checkout = Koha::OldIssue->new($issue->unblessed)->store; > >- $dbh->do(q|INSERT INTO old_issues SELECT * FROM issues WHERE issue_id = ?|, undef, $issue_id); >- > # anonymise patron checkout immediately if $privacy set to 2 and AnonymousPatron is set to a valid borrowernumber > if ( $privacy == 2) { > $dbh->do(q|UPDATE old_issues SET borrowernumber=? WHERE issue_id = ?|, undef, $anonymouspatron, $issue_id); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18966
:
65151
|
65154
|
65155
|
65156
|
65203
|
65204
|
65205
|
65206
|
65207
|
65272
| 65293 |
65294