Attachment 65302 Details for Bug 17680 – Bug 17680: [QA Follow-up] dt_from_string failing silently

[patch] Bug 17680: [QA Follow-up] dt_from_string failing silently

Bug-17680-QA-Follow-up-dtfromstring-failing-silent.patch (text/plain), 1.31 KB, created by Marcel de Rooy on 2017-07-28 08:43:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-07-28 08:43:20 UTC

Size: 1.31 KB

patch

obsolete

>From 104659d778d3359ec36bbe9cca57298ace541b19 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Fri, 28 Jul 2017 10:29:51 +0200
>Subject: [PATCH] Bug 17680: [QA Follow-up] dt_from_string failing silently
>Content-Type: text/plain; charset=utf-8
>
>This is a trivial fix, but finding the cause for a failing checkin in
>SIPServer surely was not.
>Without this simple change, I could not checkin an item while the SIP server
>just closed the connection and syslog contained nothing useful.
>
>The error can be easily reproduced without this patch by:
>    use Modern::Perl;
>    use C4::SIP::ILS::Item;
>    my $item = C4::SIP::ILS::Item->new('some_barcode');
>where some_barcode should refer to an item checked out.
>You should trigger the error (with your due date):
>    2017-07-28 23:59:00 is not an object at line 3.
>
>Why the ILS/Item.pm module still compiles without a warning, is not clear
>though.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> C4/SIP/ILS/Item.pm | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/C4/SIP/ILS/Item.pm b/C4/SIP/ILS/Item.pm
>index 7ef1d3a..12bf1aa 100644
>--- a/C4/SIP/ILS/Item.pm
>+++ b/C4/SIP/ILS/Item.pm
>@@ -25,6 +25,7 @@ use C4::Reserves;
> use Koha::Database;
> use Koha::Biblios;
> use Koha::Checkouts;
>+use Koha::DateUtils;
> use Koha::Patrons;
> use Koha::Items;
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17680: 57787 | 57788 | 57789 | 57847 | 58431 | 58432 | 58433 | 58501 | 58918 | 58919 | 58920 | 61761 | 61762 | 61763 | 62034 | 62086 | 62102 | 62103 | 62104 | 64257 | 64258 | 64259 | 64284 | 64337 | 64805 | 64806 | 64807 | 64833 | 64866 | 64867 | 64868 | 64869 | 64870 | 64871 | 64925 | 64926 | 64927 | 64928 | 64929 | 64930 | 64931 | 65302 | 65310