Bugzilla – Attachment 65325 Details for
Bug 14385
Extend OpacHiddenItems to allow specifying exempt borrower categories
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14385: Corrected issues with category code.
Bug-14385-Corrected-issues-with-category-code.patch (text/plain), 2.70 KB, created by
Mark Tompsett
on 2017-07-30 01:43:25 UTC
(
hide
)
Description:
Bug 14385: Corrected issues with category code.
Filename:
MIME Type:
Creator:
Mark Tompsett
Created:
2017-07-30 01:43:25 UTC
Size:
2.70 KB
patch
obsolete
>From e244354a62a6c9668ee6a9cfba5778ce97ffafbf Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Sat, 29 Jul 2017 21:39:32 -0400 >Subject: [PATCH] Bug 14385: Corrected issues with category code. > >When a user isn't logged in, $borrower is undef and causes error >when determining category code. Added conditional check. >--- > opac/opac-ISBDdetail.pl | 2 +- > opac/opac-MARCdetail.pl | 2 +- > opac/opac-detail.pl | 2 +- > opac/opac-search.pl | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/opac/opac-ISBDdetail.pl b/opac/opac-ISBDdetail.pl >index a0aab72..45e8af0 100755 >--- a/opac/opac-ISBDdetail.pl >+++ b/opac/opac-ISBDdetail.pl >@@ -94,7 +94,7 @@ if (scalar @items >= 1) { > > # we need to fetch the borrower info here, so we can pass the category > my $borrower = Koha::Patrons->find( { borrowernumber => $borrowernumber } ); >- $borcat = $borrower->categorycode; >+ $borcat = $borrower ? $borrower->categorycode : q{}; > } > > my @hiddenitems = GetHiddenItemnumbers( { items => \@items, borcat => $borcat }); >diff --git a/opac/opac-MARCdetail.pl b/opac/opac-MARCdetail.pl >index 3bbdb82..048cbec 100755 >--- a/opac/opac-MARCdetail.pl >+++ b/opac/opac-MARCdetail.pl >@@ -89,7 +89,7 @@ if (scalar @all_items >= 1) { > > # we need to fetch the borrower info here, so we can pass the category > my $borrower = Koha::Patrons->find( { borrowernumber => $borrowernumber } ); >- $borcat = $borrower->categorycode; >+ $borcat = $borrower ? $borrower->categorycode : q{}; > } > push @items2hide, GetHiddenItemnumbers({ items => \@all_items, borcat => $borcat }); > >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 3c49aaf..445bcdf 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -87,7 +87,7 @@ if ( scalar @all_items >= 1 ) { > > # we need to fetch the borrower info here, so we can pass the category > my $borrower = Koha::Patrons->find( { borrowernumber => $borrowernumber } ); >- $borcat = $borrower->categorycode; >+ $borcat = $borrower ? $borrower->categorycode : q{}; > } > > push @hiddenitems, >diff --git a/opac/opac-search.pl b/opac/opac-search.pl >index b829a2c..3e4c963 100755 >--- a/opac/opac-search.pl >+++ b/opac/opac-search.pl >@@ -633,7 +633,7 @@ $search_context->{'interface'} = 'opac'; > if (C4::Context->preference('OpacHiddenItemsExceptions')){ > # we need to fetch the borrower info here, so we can pass the category > my $borrower = Koha::Patrons->find( { borrowernumber => $borrowernumber } ); >- $search_context->{'category'} = $borrower->categorycode; >+ $search_context->{'category'} = $borrower ? $borrower->categorycode : q{}; > } > > for (my $i=0;$i<@servers;$i++) { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14385
:
40158
|
53483
|
53494
|
53505
|
53506
|
53507
|
55593
|
64688
|
64689
|
64690
|
64691
|
64692
|
64693
|
65322
|
65323
|
65324
|
65325
|
65376
|
65377
|
65378
|
65379
|
65380
|
65381
|
65382
|
65383
|
65384
|
65385
|
65386
|
65387
|
65388
|
65389
|
65408
|
65409
|
65410
|
65411
|
66103
|
66104
|
66105
|
66106
|
66107
|
66108
|
66109
|
66110
|
66111
|
66112
|
66113
|
66114
|
66115
|
66116
|
66117
|
66118
|
66125
|
66126
|
66127
|
66128
|
66129
|
66130
|
66131
|
66132
|
66192
|
66193
|
66194
|
66195
|
66196
|
66197
|
66198
|
66199
|
66200
|
66201
|
66202
|
66203
|
66204
|
66205
|
66206
|
66207
|
66208
|
66209
|
66210
|
66302
|
66303
|
66347
|
66361
|
66372
|
66401
|
66403
|
66520
|
66521
|
66522
|
66523
|
66524
|
66525
|
66526
|
66527
|
66528
|
66529
|
66530
|
66531
|
66532
|
66533
|
66534
|
66535
|
66536
|
66537
|
66538
|
66539
|
66540
|
66541
|
66542
|
66543
|
66544
|
66545
|
70256
|
70257
|
70258
|
70259
|
72445
|
72446
|
72447
|
72448
|
72449
|
72450
|
72451
|
72452
|
72453
|
72454
|
74001
|
78654
|
78655
|
78656
|
78657
|
78825
|
78826
|
78827
|
78828
|
80411
|
80463
|
80464
|
80465
|
80466
|
80467
|
89963
|
90038