Attachment 65328 Details for Bug 19003 – Bug 19003: Add a TestBuilder default for borrower.login_attempts

[patch] Bug 19003: Add a TestBuilder default for borrower.login_attempts

Bug-19003-Add-a-TestBuilder-default-for-borrowerlo.patch (text/plain), 1.24 KB, created by Marcel de Rooy on 2017-07-31 06:40:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marcel de Rooy

Created: 2017-07-31 06:40:33 UTC

Size: 1.24 KB

patch

obsolete

>From 02fb74de33899f32700d58dcc28e8f497b29141c Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Sat, 29 Jul 2017 17:06:52 +0200
>Subject: [PATCH] Bug 19003: Add a TestBuilder default for
> borrower.login_attempts
>Content-Type: text/plain; charset=utf-8
>
>Bug 18314 causes t/db/SIP/Message.t to fail (quite often) since
>TestBuilder fills login_attempts with a random number. (Note: Only
>when FailedLoginAttempts is non-zero.)
>Trivial fix: TestBuilder should have a zero default for login_attempts.
>
>Test plan:
>Do not yet apply this patch.
>Set pref FailedLoginAttempts to say 3.
>Run t/db_dependent/SIP/Message.t. Might fail on the password test (CQ).
>Apply this patch.
>Run t/db_dependent/SIP/Message.t again. Does not fail anymore.
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>---
> t/lib/TestBuilder.pm | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm
>index ce8f601..2df9f04 100644
>--- a/t/lib/TestBuilder.pm
>+++ b/t/lib/TestBuilder.pm
>@@ -451,6 +451,9 @@ sub _gen_blob {
> sub _gen_default_values {
>     my ($self) = @_;
>     return {
>+        Borrower => {
>+            login_attempts => 0,
>+        },
>         Item => {
>             more_subfields_xml => undef,
>         },
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 19003: 65321 | 65328 | 65329 | 65342