Bugzilla – Attachment 65337 Details for
Bug 18898
Some permissions for Reports can be bypassed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18898 - Some permissions for Reports can be bypassed
Bug-18898---Some-permissions-for-Reports-can-be-by.patch (text/plain), 1.42 KB, created by
Nick Clemens (kidclamp)
on 2017-07-31 12:13:31 UTC
(
hide
)
Description:
Bug 18898 - Some permissions for Reports can be bypassed
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-07-31 12:13:31 UTC
Size:
1.42 KB
patch
obsolete
>From 23817912d4db089fa710d4af3691edc33f1d4fef Mon Sep 17 00:00:00 2001 >From: David Cook <dcook@prosentient.com.au> >Date: Thu, 27 Jul 2017 11:58:28 +1000 >Subject: [PATCH] Bug 18898 - Some permissions for Reports can be bypassed >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >If you manually visit the following links when you only have >permission to run reports, you'll still be able to access the ability >to create and edit reports: > >/cgi-bin/koha/reports/guided_reports.pl?phase=Create%20report%20from%20SQL >/cgi-bin/koha/reports/guided_reports.pl?phase=Edit%20SQL > >This patch ties these 2 unaccounted for phases to the create_reports >permission. > >With patch, issue no longer can be reproduced. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > reports/guided_reports.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reports/guided_reports.pl b/reports/guided_reports.pl >index b81e84f..bfd0a76 100755 >--- a/reports/guided_reports.pl >+++ b/reports/guided_reports.pl >@@ -53,7 +53,7 @@ my $usecache = Koha::Caches->get_instance->memcached_cache; > > my $phase = $input->param('phase') // ''; > my $flagsrequired; >-if ( $phase eq 'Build new' ) { >+if ( ( $phase eq 'Build new' ) || ( $phase eq 'Create report from SQL' ) || ( $phase eq 'Edit SQL' ) ){ > $flagsrequired = 'create_reports'; > } > elsif ( $phase eq 'Use saved' ) { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18898
:
65292
|
65320
| 65337