Bugzilla – Attachment 65361 Details for
Bug 18906
Superlibrarian and budget_manage_all users should always see all funds
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 18906: Display all funds the logged in user can use
Bug-18906-Display-all-funds-the-logged-in-user-can.patch (text/plain), 1.50 KB, created by
Nick Clemens (kidclamp)
on 2017-07-31 15:29:38 UTC
(
hide
)
Description:
Bug 18906: Display all funds the logged in user can use
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2017-07-31 15:29:38 UTC
Size:
1.50 KB
patch
obsolete
>From 0c4263ac917686fa3ab6cab911cf9d941b61134b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 6 Jul 2017 18:10:10 -0300 >Subject: [PATCH] Bug 18906: Display all funds the logged in user can use > >There are complex conditions to know if a librarian can use a fund, we >cannot do that with a SQL query, we need to use C4::Budgets::CanUserUseBudget > >When this patch is applied then all funds are visible to both >superlibrarian patrons and patrons with all acq permissions > >Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > admin/aqbudgets.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/admin/aqbudgets.pl b/admin/aqbudgets.pl >index 0dce9dd..7e85254 100755 >--- a/admin/aqbudgets.pl >+++ b/admin/aqbudgets.pl >@@ -234,7 +234,7 @@ if ( $op eq 'list' ) { > ); > > my @budgets = @{ >- GetBudgetHierarchy( $$period{budget_period_id}, C4::Context->userenv->{branch}, ( $show_mine ? $borrower_id : 0 )) >+ GetBudgetHierarchy( $$period{budget_period_id}, undef, ( $show_mine ? $borrower_id : 0 )) > }; > > my $period_total = 0; >@@ -245,6 +245,7 @@ if ( $op eq 'list' ) { > my @budgets_to_display; > foreach my $budget (@budgets) { > # PERMISSIONS >+ next unless CanUserUseBudget($borrowernumber, $budget, $staffflags); > unless(CanUserModifyBudget($borrowernumber, $budget, $staffflags)) { > $budget->{'budget_lock'} = 1; > } >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 18906
:
64874
|
65288
| 65361